Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chttpd): Always show browser login popup #5369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chttpd): Always show browser login popup #5369

wants to merge 1 commit into from

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented Dec 19, 2024 •
edited
Loading

Always show the browser login popup, no matter
which option of require_valid_user or
require_valid_user_except_for_up is set.

@big-r81
fix(chttpd): Always show browser login popup
0426a7d 
Always show the browser login popup, no matter
which option of `require_valid_user` or
`require_valid_user_except_up` is set.
@big-r81 big-r81 marked this pull request as ready for review January 8, 2025 07:03
@big-r81
Copy link
Contributor Author

big-r81 commented Jan 8, 2025 •
edited
Loading

Additional finding

Abbreviations

rvu = request_valid_user
rvuefu = request_valid_user_except_for_up

Before #5370 (use auth for live node checks)

rvu rvuefu start dev server
false false false
true false false
false true false
true true false

After #5370

rvu rvuefu start dev server
false false true
true false true
false true false
true true true

With this PR

rvu rvuefu start dev server
false false true
true false true
false true true
true true true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@big-r81