[CXF-9105] add synchronized to the principal iteration #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Jan 31, 2025
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Jan 31, 2025
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/DefaultLogEventMapper.java
Show resolved
Hide resolved
|
Thank you @sstremler , a few comments but LGTM otherwise! |
sstremler
force-pushed
the
CXF-9105-concurrent-modification-exception-in-logging
branch
2 times, most recently
from
1ee7b7d to
e760d0d
Compare
Thank you, I added the changes you suggested. |
reta
approved these changes
Jan 31, 2025
sstremler
force-pushed
the
CXF-9105-concurrent-modification-exception-in-logging
branch
from
e760d0d to
3b887d0
Compare
reta
pushed a commit
that referenced
this pull request
Feb 1, 2025
(cherry picked from commit 96aca2e)
reta
pushed a commit
that referenced
this pull request
Feb 2, 2025
reta
pushed a commit
that referenced
this pull request
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CXF-9105