fix: do not log complete stream causing OOM #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the hashCode instead of toString to avoid dumping all the file content in memory and in log because of https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/io/CachedOutputStream.java#L423 This cause OOM on our app.
Thom-x
changed the title
reta
reviewed
Feb 6, 2025
| @@ -119,7 +119,7 @@ private void clean(Collection<DelayedCloseable> closeables) { | |||
| final DelayedCloseable next = iterator.next(); | |||
| try { | |||
| iterator.remove(); | |||
| LOG.warning("Unclosed (leaked?) stream detected: " + next.closeable); | |||
| LOG.warning("Unclosed (leaked?) stream detected: " + next.closeable.hashCode()); | |||
There was a problem hiding this comment.
Thank you @Thom-x , this was certainly not expected ...
reta
approved these changes
Feb 6, 2025
reta
pushed a commit
that referenced
this pull request
Feb 6, 2025
Log the hashCode instead of toString to avoid dumping all the file content in memory and in log because of https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/io/CachedOutputStream.java#L423 This cause OOM on our app. (cherry picked from commit 1c1d687)
reta
pushed a commit
that referenced
this pull request
Feb 6, 2025
Log the hashCode instead of toString to avoid dumping all the file content in memory and in log because of https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/io/CachedOutputStream.java#L423 This cause OOM on our app. (cherry picked from commit 1c1d687) (cherry picked from commit 24bb53c)
reta
pushed a commit
that referenced
this pull request
Feb 7, 2025
Log the hashCode instead of toString to avoid dumping all the file content in memory and in log because of https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/io/CachedOutputStream.java#L423 This cause OOM on our app. (cherry picked from commit 1c1d687) (cherry picked from commit 24bb53c) (cherry picked from commit 20cfa99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the hashCode instead of toString to avoid dumping all the file content in memory and in log because of https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/io/CachedOutputStream.java#L423
This cause OOM on our app.