Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root README.md and other documentation with latest changes #1113

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

milenkovicm
Copy link
Contributor

and cleanup some of the context.

Which issue does this PR close?

Closes #1105.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@milenkovicm milenkovicm marked this pull request as draft November 13, 2024 21:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 13, 2024
and cleanup some of the context.

Relates to apache#1105
@milenkovicm milenkovicm force-pushed the doc_update_root_readme branch from c7bb151 to e7ccbb1 Compare November 14, 2024 16:40
@milenkovicm milenkovicm changed the title Update root README.md adding example how to use ... Update root README.md and other documentation with latest changes Nov 14, 2024
@milenkovicm milenkovicm force-pushed the doc_update_root_readme branch from 1d78676 to 315b775 Compare November 14, 2024 18:47
@milenkovicm milenkovicm marked this pull request as ready for review November 14, 2024 18:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have a rest implementation that works? I was testing out the other day and couln't get a response from the REST endpoint. I may have misconfigured the cluster on AWS, though. Was able to run jobs against it, just not use the REST API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's a optional feature (rest-api) of scheduler crate and its disabled by default. should work when enabled, otherwise its a bug and should be fixed

@milenkovicm
Copy link
Contributor Author

thanks for your review @tbar4

README.md Outdated Show resolved Hide resolved
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, but LGTM.

README.md Outdated Show resolved Hide resolved
@milenkovicm milenkovicm force-pushed the doc_update_root_readme branch from 351930f to 9797927 Compare November 17, 2024 17:18
@andygrove andygrove merged commit 68b2277 into apache:main Nov 19, 2024
15 checks passed
@milenkovicm milenkovicm deleted the doc_update_root_readme branch November 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation with SessionContextExt
3 participants