refactor: consolidate ballista tests #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... use rstest to run same tests for standalone and remote.
milenkovicm
changed the title
andygrove
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was a bit of repeatibility in the test, same tests were used for
standaloneandremotecontext.this PR introduces:
standaloneandremoteINSERT INTO) to catch if datafusion brings new changesthey are still disabled as i could not make them connect to docker deamon)Which issue does this PR close?
Closes none.
Rationale for this change
simplification and de-duplication of tests
What changes are included in this PR?
standaloneandremoteINSERT INTO) to catch if datafusion brings new changesthey are still disabled as i could not make them connect to docker deamon)follow up PR will move files to centralised location as there may be few duplicates
Are there any user-facing changes?
No, just tests