Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix clippy issues after rust update (1.83.0) #1143

Merged
merged 1 commit into from
Nov 30, 2024
Merged

chore: Fix clippy issues after rust update (1.83.0) #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ballista/client/tests/context_unsupported.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ mod common;
///
/// It provides indication if/when datafusion
/// gets support for them
#[cfg(test)]
mod unsupported {
use crate::common::{remote_context, standalone_context};
Expand Down
7 changes: 4 additions & 3 deletions ballista/core/src/extension.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ pub trait SessionStateExt {

/// [SessionConfig] extension with methods needed
/// for Ballista configuration
pub trait SessionConfigExt {
/// Creates session config which has
/// ballista configuration initialized
Expand Down Expand Up @@ -315,7 +314,8 @@ impl SessionConfigHelperExt for SessionConfig {
value
);
if let Err(e) = s.options_mut().set(key, value) {
log::warn!(
// there is not much we can do about this error at the moment
log::debug!(
"could not set configuration key: `{}`, value: `{}`, reason: {}",
key,
value,
Expand All @@ -334,7 +334,8 @@ impl SessionConfigHelperExt for SessionConfig {
value
);
if let Err(e) = self.options_mut().set(key, value) {
log::warn!(
// there is not much we can do about this error at the moment
log::debug!(
"could not set configuration key: `{}`, value: `{}`, reason: {}",
key,
value,
Expand Down
1 change: 0 additions & 1 deletion ballista/core/src/serde/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ impl BallistaLogicalExtensionCodec {
/// position is important with encoding process
/// as position of used codecs is needed
/// so the same codec can be used for decoding
fn try_any<R>(
&self,
mut f: impl FnMut(&dyn LogicalExtensionCodec) -> Result<R>,
Expand Down
1 change: 0 additions & 1 deletion ballista/executor/src/execution_engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ use std::fmt::Debug;
use std::sync::Arc;

/// Execution engine extension point
pub trait ExecutionEngine: Sync + Send {
fn create_query_stage_exec(
&self,
Expand Down
1 change: 0 additions & 1 deletion ballista/executor/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ impl Executor {

/// Create a new executor instance with given [RuntimeEnv],
/// [ScalarUDF], [AggregateUDF] and [WindowUDF]
#[allow(clippy::too_many_arguments)]
pub fn new(
metadata: ExecutorRegistration,
Expand Down
6 changes: 3 additions & 3 deletions ballista/scheduler/src/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl<'a> DisplayableBallistaExecutionPlan<'a> {
plan: &'a dyn ExecutionPlan,
metrics: &'a Vec<MetricsSet>,
}
impl<'a> fmt::Display for Wrapper<'a> {
impl fmt::Display for Wrapper<'_> {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
let t = DisplayFormatType::Default;
let mut visitor = IndentVisitor {
Expand Down Expand Up @@ -121,7 +121,7 @@ struct IndentVisitor<'a, 'b> {
metric_index: usize,
}

impl<'a, 'b> ExecutionPlanVisitor for IndentVisitor<'a, 'b> {
impl ExecutionPlanVisitor for IndentVisitor<'_, '_> {
type Error = fmt::Error;
fn pre_visit(
&mut self,
Expand Down Expand Up @@ -150,7 +150,7 @@ impl<'a, 'b> ExecutionPlanVisitor for IndentVisitor<'a, 'b> {
}
}

impl<'a> ToStringifiedPlan for DisplayableBallistaExecutionPlan<'a> {
impl ToStringifiedPlan for DisplayableBallistaExecutionPlan<'_> {
fn to_stringified(
&self,
plan_type: datafusion::logical_expr::PlanType,
Expand Down
Loading