Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[comet-parquet-exec] Add Native Scan to CometReadBenchmark #1150

Open
wants to merge 4 commits into
base: comet-parquet-exec
Choose a base branch
from
Open

[comet-parquet-exec] Add Native Scan to CometReadBenchmark #1150

wants to merge 4 commits into from

Conversation

mbutrovich
Copy link
Contributor

I still need to convince myself that CometNativeScan is being generated for the scenarios when it's enabled.

CometReadBenchmark-jdk11-results.txt

@mbutrovich mbutrovich changed the base branch from main to comet-parquet-exec December 7, 2024 02:49
parthchandra
parthchandra reviewed Dec 8, 2024
View reviewed changes
Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't CometConf.COMET_FULL_NATIVE_SCAN_ENABLED true by default in branch comet-parquet-exec ?

@mbutrovich
Copy link
Contributor Author

mbutrovich commented Dec 9, 2024 •
edited
Loading

I'll check if the benchmarks use the settings from CometTestBase or the global defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthchandra parthchandra parthchandra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbutrovich @parthchandra