-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for array_repeat
array function
#1205
base: main
Are you sure you want to change the base?
Conversation
self.create_expr(expr.left.as_ref().unwrap(), Arc::clone(&input_schema))?; | ||
let count_expr = | ||
self.create_expr(expr.right.as_ref().unwrap(), Arc::clone(&input_schema))?; | ||
// Cast count_expr from Int32 to Int64 to support df count argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are manually casting the count_expr to Int64 datatype.
We can remove this once this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jatin510. This looks good overall. Testing could be more comprehensive to cover edge cases such as nulls for either param and covering different data types.
I am working on establishing a better framework for type checks and testing for the array functions in #1339.
Perhaps we can go ahead and merge this PR and then improve the tests once #1339 is merged. Let's see what other reviewers think.
Thanks @andygrove for the review. |
I added |
@jatin510 builds are failing:
|
fixed @andygrove |
Which issue does this PR close?
Part of #1042
Rationale for this change
What changes are included in this PR?
Added support for
array_repeat
expression in cometHow are these changes tested?
Added test case for
array_repeat
in CometExpressionSuite.scala