Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for array_min, array_max, sort_array, array_zip & array_union #1227

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dharanad
Copy link
Contributor

@dharanad dharanad commented Jan 7, 2025

Which issue does this PR close?

Part of #1042

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Signed-off-by: Dharan Aditya <[email protected]>
Signed-off-by: Dharan Aditya <[email protected]>
Signed-off-by: Dharan Aditya <[email protected]>
Signed-off-by: Dharan Aditya <[email protected]>
Signed-off-by: Dharan Aditya <[email protected]>
Introduced `ArrayMinMax` struct to handle both ArrayMin and ArrayMax functionalities, consolidating shared logic. Implemented evaluation logic, schema compatibility, and planner integration for `ArrayMinMax` expressions. This enhances functionality by providing min/max operations on list arrays.

Signed-off-by: Dharan Aditya <[email protected]>
@andygrove
Copy link
Member

@dharanad would it be possible to break this out into one PR per function? It will make reviews much easier.

@dharanad
Copy link
Contributor Author

@andygrove Sure i will break them into multiple PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants