chore: Remove redundant processing from exprToProtoInternal #1351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
We have two very similar methods,
exprToProto
andexprToProtoInternal
.exprToProto
performs a transformation on the expression tree to handle decimal promotion and then calls into the recursive methodexprToProtoInternal
to perform the translation to protobuf.Within
exprToProtoInternal
we should only recurse intoexprToProtoInternal
but in some cases we were callingexprToProto
instead,. This was not harmful but is performing redundant work.What changes are included in this PR?
exprToProto
withexprToProtoInternal
withinexprToProtoInternal
How are these changes tested?