Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Passthrough condition in StaticInvoke case block #1392

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

EmilyMatt
Copy link
Contributor

Which issue does this PR close?

Closes #1391 .

Rationale for this change

It is a logic error.

What changes are included in this PR?

Moved to a direct comparator instead of checking that Class isInstanceOf Class

How are these changes tested?

I believe this is an inherent language feature, it does not need a TestSuite.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.06%. Comparing base (f09f8af) to head (eb42ec9).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1392       +/-   ##
=============================================
- Coverage     56.12%   39.06%   -17.06%     
- Complexity      976     2071     +1095     
=============================================
  Files           119      263      +144     
  Lines         11743    60746    +49003     
  Branches       2251    12909    +10658     
=============================================
+ Hits           6591    23733    +17142     
- Misses         4012    32530    +28518     
- Partials       1140     4483     +3343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirmed that this resolves the following compiler warning. Thanks @EmilyFlarionIO.

[WARNING] /Users/andy/git/apache/datafusion-comet/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:2131: non-variable type argument org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils in type Class[org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils] (the underlying of Class[org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils]) is unchecked since it is eliminated by erasure

@andygrove andygrove merged commit 11651d4 into apache:main Feb 12, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StaticInvoke class checked with elided types
4 participants