fix: Remove more cast.rs logic from parquet_support.rs for experimental native scans #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
=============================================
- Coverage 56.12% 39.32% -16.81%
- Complexity 976 2081 +1105
=============================================
Files 119 265 +146
Lines 11743 61132 +49389
Branches 2251 12962 +10711
=============================================
+ Hits 6591 24039 +17448
- Misses 4012 32587 +28575
- Partials 1140 4506 +3366 ☔ View full report in Codecov by Sentry. |
|
@mbutrovich I opened #1415 which modifies |
parthchandra
approved these changes
Feb 18, 2025
andygrove
approved these changes
Feb 18, 2025
kazuyukitanimura
pushed a commit
that referenced
this pull request
Feb 20, 2025
…ceberg_compat readers (#1415) major changes : - allow Uint64 to decimal and FixedWidthBinary to Binary conversions in complex readers - do not enable prefetch reads in tests if complex reader is enabled - fix more incompatible checks in uint_8/uint_16 tests - skip datetime rebase tests for complex readers (not supported) There may be conflicts between this and #1413 (@mbutrovich) which removes the `cast_supported` method but can be reconciled afterwards Without #1413 the failure counts are: ``` native_datafusion: Tests: succeeded 658, failed 19, canceled 4, ignored 54, pending 0 native_iceberg_compat: Tests: succeeded 662, failed 15, canceled 4, ignored 54, pending 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
See #1387 for more discussion on this topic.
What changes are included in this PR?
The rules for whether we can convert between types when building our
SchemaAdaptercome from cast.rs, which may or may not be accurate. For example, I removed this check and native_datafusion went from 27 failures to 22 failures.How are these changes tested?
Local tests on the experimental scans.
native_datafusion:
Tests: succeeded 657, failed 22, canceled 2, ignored 54, pending 0native_iceberg_compat:
Tests: succeeded 649, failed 30, canceled 2, ignored 54, pending 0