-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update released version in documentation #1418
Conversation
@@ -65,13 +65,13 @@ metadata: | |||
spec: | |||
type: Scala | |||
mode: cluster | |||
image: ghcr.io/apache/datafusion-comet:spark-3.4-scala-2.12-0.2.0 | |||
image: ghcr.io/apache/datafusion-comet:spark-3.4-scala-2.12-0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really be 0.6.0 but the Docker image failed to publish. I filed #1417
version = "0.6.0" | ||
version = "0.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been updated as part of #1404 but I missed this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
=============================================
- Coverage 56.12% 39.32% -16.81%
- Complexity 976 2085 +1109
=============================================
Files 119 265 +146
Lines 11743 61132 +49389
Branches 2251 12962 +10711
=============================================
+ Hits 6591 24040 +17449
- Misses 4012 32587 +28575
- Partials 1140 4505 +3365 ☔ View full report in Codecov by Sentry. |
## Update released version number in documentation | ||
|
||
- We provide direct links to the jar files in Maven | ||
- The Kubernetes page needs updating once the Docker image has been published to GitHub Container Regsistry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can mention this PR #1418 as an example what needs to be changed with the new version? Hope we can get this automated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @andygrove
Which issue does this PR close?
N/A
Rationale for this change
Now that 0.6.0 has been released, we need to update the documentation to reflect that.
What changes are included in this PR?
How are these changes tested?