fix: clean up iceberg integration APIs #2032
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
============================================
+ Coverage 56.12% 58.68% +2.55%
- Complexity 976 1260 +284
============================================
Files 119 134 +15
Lines 11743 13100 +1357
Branches 2251 2396 +145
============================================
+ Hits 6591 7688 +1097
- Misses 4012 4177 +165
- Partials 1140 1235 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| public BatchReader(AbstractColumnReader[] columnReaders) { | ||
| // Todo: set useDecimal128 and useLazyMaterialization | ||
| int numColumns = columnReaders.length; | ||
| public BatchReader(int numColumns) { |
There was a problem hiding this comment.
Where are the column readers created and how are they passed in to the BatchReader? (Or does init have to be called?)
(Also, this constructor sets isInitialized to true which is probably not the case any more.)
There was a problem hiding this comment.
@parthchandra Thanks for taking a look at this PR!
The column readers are created here and passed to Batch Reader at here
isInitialized is still true.
There was a problem hiding this comment.
passed to Batch Reader at here
This does not sound correct. BatchReader has no API to set a column reader other than the constructor changed by this PR. The only other way to set column readers is by calling init which will then create the appropriate column readers.
Also, I notice that the current version of the constructor ignores the column readers passed in.
Any BatchReader created with this constructor (either this PR or the current version) will have an array of nulls as the column readers.
How is such a BatchReader usable (or useful)?
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?