Skip to content

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 2, 2025

Which issue does this PR close?

N/A

Rationale for this change

Making life simpler when debugging. We previously asked developers to modify the Cargo.toml file. I just exposed the backtrace feature instead.

What changes are included in this PR?

Expose backtrace feature. Update docs.

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.49%. Comparing base (f09f8af) to head (0165dc2).
⚠️ Report is 567 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2515      +/-   ##
============================================
+ Coverage     56.12%   58.49%   +2.36%     
- Complexity      976     1447     +471     
============================================
  Files           119      146      +27     
  Lines         11743    13550    +1807     
  Branches       2251     2356     +105     
============================================
+ Hits           6591     7926    +1335     
- Misses         4012     4390     +378     
- Partials       1140     1234      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@parthchandra
Copy link
Contributor

FWIW, there is also

Panic { msg: String },
which allows us to return a result with a backtrace.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove

Its been a while since backtraces introduced in DF and I was thinking to replace Comet errors with DFs? So they would have backtrace capabilities and would be easier to navigate through Comet and DF, WDYT?

@andygrove
Copy link
Member Author

Thanks @andygrove

Its been a while since backtraces introduced in DF and I was thinking to replace Comet errors with DFs? So they would have backtrace capabilities and would be easier to navigate through Comet and DF, WDYT?

I don't know enough about this. Would you mind writing up an issue to explain in more detail?

@andygrove andygrove merged commit 64a1c18 into apache:main Oct 3, 2025
147 of 149 checks passed
@andygrove andygrove deleted the backtrace branch October 3, 2025 15:51
@comphead
Copy link
Contributor

comphead commented Oct 3, 2025

Thanks @andygrove
Its been a while since backtraces introduced in DF and I was thinking to replace Comet errors with DFs? So they would have backtrace capabilities and would be easier to navigate through Comet and DF, WDYT?

I don't know enough about this. Would you mind writing up an issue to explain in more detail?

DataFusion uses error macros (for example exec_err! wraps ExecutionError) which wraps the error and adds the backtrace if needed. It works in DF to locate approximated root cause.

But what comes to my mind now is: DF backtrace should include Comet entrypoint anyway, because it is caller code, so we don't really need to use error macros in Comet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants