Snowflake: Improve support for reserved keywords for table factor #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 25, 2025
src/dialect/snowflake.rs
Outdated
Comment on lines
509
to
512
| if matches!( | ||
| parser.peek_token().token, | ||
| Token::Number(_, _) | Token::Placeholder(_) | ||
| ) => |
There was a problem hiding this comment.
would it make sense to use the peek_for_limit_options helper method here?
yoavcloud
force-pushed
the
sf_reserved_kws_table_factor
branch
from
29fc9b9 to
f7d6322
Compare
iffyio
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned logic in the
Dialecttrait to other similar flows (is_column_alias,is_table_alias, etc) and added a list of reserved keywords in Snowflake.