feat: support ApproxDistinct with utf8view #15200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
approved these changes
Mar 13, 2025
| query III | ||
| SELECT c2, approx_distinct(c1), approx_distinct(c5) FROM aggregate_test_100_utf8view GROUP BY c2 ORDER BY c2; | ||
| ---- | ||
| 1 5 22 |
Weijun-H
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Thanks @zhuqi-lucas , LGTM. I left some comments for you to consider.
| where | ||
| T: OffsetSizeTrait, | ||
| { | ||
| /// new approx_distinct accumulator |
There was a problem hiding this comment.
I understand you follow the previous pattern, but the comment seems unclear vague
Suggested change
| /// new approx_distinct accumulator |
There was a problem hiding this comment.
Good point @Weijun-H , addressed in latest PR.
| c5 | ||
| FROM aggregate_test_100; | ||
|
|
||
| # Test approx_distinct for varchar / int |
There was a problem hiding this comment.
Suggested change
| # Test approx_distinct for varchar / int | |
| # Test approx_distinct for varchar(with Utf8View) / int |
There was a problem hiding this comment.
Thank you @Weijun-H , addressed in latest PR.
|
Thanks @zhuqi-lucas and @alamb |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
VARCHARfromUtf8toUtf8View#15096Rationale for this change
support ApproxDistinct with utf8view
What changes are included in this PR?
support ApproxDistinct with utf8view
Are these changes tested?
Yes
Are there any user-facing changes?
support ApproxDistinct with utf8view