Skip to content

Add utf8view benchmark for aggregate topk #15518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Apr 1, 2025

Which issue does this PR close?

Since we have merged the utf8view support for aggregate topk, so also add the corresponding benchmark code in this PR.

#15152

Close part of #15096

Rationale for this change

Since we have merged the utf8view support for aggregate topk, so also add the corresponding benchmark code in this PR.

What changes are included in this PR?

Since we have merged the utf8view support for aggregate topk, so also add the corresponding benchmark code in this PR.

Are these changes tested?

Yes

Benchmark Min Time Median Time Max Time Performance Change
Utf8 - time-series rows 987.96ms 995.70ms 1.0035s +4.58% ~ +6.89%
Utf8 - worst-case rows 1.1663s 1.1848s 1.2038s +3.64% ~ +8.62%
Utf8View - time-series rows 984.49ms 992.39ms 1.0006s +2.68% ~ +5.12%
Utf8View - worst-case rows 1.1713s 1.1918s 1.2129s +0.99% ~ +6.09%

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate common Related to common crate labels Apr 1, 2025
@zhuqi-lucas zhuqi-lucas force-pushed the utf8view_benchmark_aggregation_topk branch from 3392cec to 4387774 Compare April 1, 2025 04:56
@github-actions github-actions bot removed the common Related to common crate label Apr 1, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhuqi-lucas !

@comphead comphead merged commit 7317198 into apache:main Apr 2, 2025
29 checks passed
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants