Skip to content

fix tests in page_pruning when filter pushdown is enabled by default #16794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

XiangpengHao
Copy link
Contributor

Which issue does this PR close?

This should unblock our way to enable filter pushdown by default.

Rationale for this change

When working on #16711 we keep getting the annoying test error because these two test cases are written without filter-pushdown in mind, i.e., the assertions of row counts are before filter is applied

This PR makes it more explicit what to expect with and without filter pushdown.

cc @alamb I think with this change we will get a green light in #16711

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jul 15, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you @XiangpengHao 🙏

@alamb alamb merged commit 38b87bf into apache:main Jul 16, 2025
27 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 16, 2025

Thank you @XiangpengHao and @xudong963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants