feat: enhance support for Decimal128 and Decimal256 #16831
+178
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods distance, new_zero, new_one, new_ten for Decimal128, Decimal256
github-actions
bot
added
optimizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Enhancing support for
ScalarValue::Decimal128andScalarValue::Decimal256What changes are included in this PR?
Decimal128andDecimal256toScalarValuein functions:new_one,new_zero,new_ten,distanceDecimal256:is_zeroandis_oneAre these changes tested?
Unit tests for optimiser utils
Are there any user-facing changes?
No