Make SUM and AVG Aggregate Type Coercion Explicit
#7369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
tustvold
commented
Aug 22, 2023
| @@ -1010,40 +1010,7 @@ fn aggregate_expressions( | |||
| | AggregateMode::SinglePartitioned => Ok(aggr_expr | |||
| .iter() | |||
| .map(|agg| { | |||
| let pre_cast_type = if let Some(Sum { | |||
There was a problem hiding this comment.
We no longer need this custom logic, it is handled automatically by the optimizer
alamb
changed the title
SUM and AVG Aggregate Type Coercion Explicit
alamb
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Thank you @tustvold
I think this logic was left over from an earlier time when DataFusion did the type coercion at physical plan time (rather than during logical planning)
I went through it carefully and it makes much more sense to me than what is on master
| DataType::Float64 | DataType::Float32 => Ok(DataType::Float64), | ||
| DataType::Int64 => Ok(DataType::Int64), | ||
| DataType::UInt64 => Ok(DataType::UInt64), | ||
| DataType::Float64 => Ok(DataType::Float64), |
There was a problem hiding this comment.
It looked like we lost support for Float32 -- but then I see the test below for it, so 👍 (presumably what happens is the arguments are coerced first and arg_type refers to the post coerced type)
| @@ -70,7 +70,7 @@ fn subquery_filter_with_cast() -> Result<()> { | |||
| \n Inner Join: Filter: CAST(test.col_int32 AS Float64) > __scalar_sq_1.AVG(test.col_int32)\ | |||
| \n TableScan: test projection=[col_int32]\ | |||
| \n SubqueryAlias: __scalar_sq_1\ | |||
| \n Aggregate: groupBy=[[]], aggr=[[AVG(test.col_int32)]]\ | |||
| \n Aggregate: groupBy=[[]], aggr=[[AVG(CAST(test.col_int32 AS Float64))]]\ | |||
There was a problem hiding this comment.
it is actually nice to see the explicit cast I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Currently various accumulators contain internal logic to coerce inputs to supported types, this has a few issues:
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?