Rename packages #18
Merged
Rename packages #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I now have everything living in
org.apache.spark.sql.datasketchesSome of the traits we extend use constructs like
Seq[AbstractDataType], which is fine except thatAbstractDataTypeis declared asprivate[sql], meaning it's only visible to things inorg.apache.spark.sql. We might be able to get away with usingSeq[DataType]but that's a subtype of its abstract parent and not everything inherits from it. Similarly, the genericNumericTypeis also not public.These seem like design flaws in Spark, IMHO, but I'm not going to try getting them to change that at this point.