-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDO-844: Add SampleReadQuery test methods with variables of type String #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % some minor questions/suggestions
tck/src/main/java/org/apache/jdo/tck/lifecycle/PMsCanSharePCClassesButNotPCInstances.java
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCAppPerson.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSPerson.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/companyAnnotatedJPA/JPAAppPerson.java
Outdated
Show resolved
Hide resolved
tck/src/main/resources/jdo/applicationidentity/org/apache/jdo/tck/pc/company/package.jdo
Outdated
Show resolved
Hide resolved
@@ -275,6 +278,9 @@ has application identity. | |||
<property name="phoneNumbers" persistence-modifier="persistent"> | |||
<map key-type="String" value-type="String"/> | |||
</property> | |||
<property name="languages" persistence-modifier="persistent"> | |||
<collection type="String"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be <collection element-type="String"/>
?
tck/src/main/resources/jdo/datastoreidentity/org/apache/jdo/tck/pc/company/package.jdo
Outdated
Show resolved
Hide resolved
tck/src/main/resources/jdo/datastoreidentity/org/apache/jdo/tck/pc/company/package.jdo
Outdated
Show resolved
Hide resolved
tck/src/main/resources/sql/derby/applicationidentity/schema.sql
Outdated
Show resolved
Hide resolved
|
No description provided.