[wip](E2E)Update Doris E2E Test Container to Use Latest Version #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinlee19
changed the title
vinlee19
force-pushed
the
update_e2e_doris_version
branch
3 times, most recently
from
809b36c to
e028aff
Compare
JNSimba
reviewed
Mar 17, 2025
JNSimba
reviewed
Mar 17, 2025
Comment on lines
65
to
67
| tEnv.getConfig() | ||
| .getConfiguration() | ||
| .setString("table.local-time-zone", ZoneId.systemDefault().getId()); |
There was a problem hiding this comment.
Don't we need to add other reads itcase?
JNSimba
reviewed
Mar 17, 2025
Comment on lines
+88
to
+90
| "sh", | ||
| "-c", | ||
| "chmod -R 644 /root/be/conf/be.conf /root/fe/conf/fe.conf && chmod -R 755 /root/be/conf /root/fe/conf && chown -R root:root /root/be/conf /root/fe/conf") |
There was a problem hiding this comment.
What does this action mainly do?
JNSimba
reviewed
Mar 17, 2025
| @@ -19,13 +19,13 @@ CUR_DATE=`date +%Y%m%d-%H%M%S` | |||
|
|
|||
| PPROF_TMPDIR="$DORIS_HOME/log/" | |||
|
|
|||
| JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log -Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Djavax.security.auth.useSubjectCredsOnly=false -Dsun.security.krb5.debug=true -Dsun.java.command=DorisBE -XX:-CriticalJNINatives" | |||
| JAVA_OPTS="-Xmx2048m -DlogPath=$DORIS_HOME/log/jni.log -Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Djavax.security.auth.useSubjectCredsOnly=false -Dsun.security.krb5.debug=true -Dsun.java.command=DorisBE -XX:-CriticalJNINatives" | |||
There was a problem hiding this comment.
Does this container need more memory?
There was a problem hiding this comment.
2048m is default configuration for Apache Doris 2.1.x
JNSimba
reviewed
Mar 17, 2025
Comment on lines
190
to
215
| private void waitForContainerRunning() { | ||
| LOG.info("Waiting for Doris services to be accessible..."); | ||
|
|
||
| try { | ||
| Awaitility.await("FE HTTP Service") | ||
| .atMost(5, TimeUnit.MINUTES) | ||
| .pollInterval(1, TimeUnit.SECONDS) | ||
| .until( | ||
| () -> { | ||
| try { | ||
| ExecResult result = | ||
| dorisContainer.execInContainer( | ||
| "curl", | ||
| "-s", | ||
| "-o", | ||
| "/dev/null", | ||
| "-w", | ||
| "%{http_code}", | ||
| "-m", | ||
| "2", | ||
| "http://localhost:" + FE.HTTP_PORT); | ||
| boolean ready = result.getStdout().equals("200"); |
There was a problem hiding this comment.
You can directly use the verification method in DorisContaier.startContainer
fix timezone format code modify workflow images modify fe.conf to avoid oom modify flight port modify workflow modify workflow modify workflow modify workflow modify workflow modify workflow update workflow
vinlee19
force-pushed
the
update_e2e_doris_version
branch
from
e028aff to
fc3b4e1
Compare
vinlee19
force-pushed
the
update_e2e_doris_version
branch
from
37a3514 to
0337399
Compare
vinlee19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR includes several enhancements:
Docker Image Update
yagagaga/doris-standalone:2.1.7. The Docker imageyagagagaga/doris-standalone:2.1.7is maintained by @yagagagaga, who is an active contributor to the Apache Doris community.Workflow Optimizations
github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repositoryProblem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...