Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick "[enhance](PrefetchReader) Make the prefetch timeout one config (#27371)" #27530

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Nov 24, 2023

Proposed changes

Issue Number: close #xxx
same as master #27371

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@ByteYue
Copy link
Contributor Author

ByteYue commented Nov 24, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.96% (7984/21031)
Line Coverage: 29.68% (64777/218254)
Region Coverage: 29.12% (33374/114609)
Branch Coverage: 24.97% (17137/68624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b63cf507ced7efef8e3af5625b1b2f8e4c2905d5_b63cf507ced7efef8e3af5625b1b2f8e4c2905d5/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.67 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 71 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17163035638 Bytes

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ByteYue
Copy link
Contributor Author

ByteYue commented Dec 20, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.77% (7987/21144)
Line Coverage: 29.48% (64890/220094)
Region Coverage: 28.96% (33384/115296)
Branch Coverage: 24.83% (17128/68986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5420e01b7cc75444bd5863262d98cb45fd838521_5420e01b7cc75444bd5863262d98cb45fd838521/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 22, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang
Copy link
Contributor

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.76% (7993/21170)
Line Coverage: 29.46% (64932/220407)
Region Coverage: 28.93% (33406/115467)
Branch Coverage: 24.80% (17138/69096)
Coverage Report: http://coverage.selectdb-in.cc/coverage/aca4331f9042afc70c2c7efddf06f153196aa983_aca4331f9042afc70c2c7efddf06f153196aa983/report/index.html

@xiaokang xiaokang merged commit 2bc39d5 into apache:branch-2.0 Dec 22, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants