-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](properties) Refactor property #46833
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ba38ff4
to
01bd487
Compare
// always try to add hdfs properties, because in previous version, we don't have fs.xxx.support properties, | ||
// the hdfs properties may be loaded from the configuration file. | ||
// so there is no way to guess the storage type. | ||
storageProperties.add(new HDFSProperties(origProps)); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do this, then S3 (or any other cloud storage using the HDFS protocol) will inherit HDFS parameters. In other words, we would have to set hadoop.name and hadoop.config.resources. Does that make sense?
…nd file type errors.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)