Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](kerberos) use ticket cache instead of principal+keytab on BE side #47299

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions be/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,9 @@ if ((ARCH_AMD64 OR ARCH_AARCH64) AND OS_LINUX)
hadoop_hdfs
)
add_definitions(-DUSE_HADOOP_HDFS)
# USE_DORIS_HADOOP_HDFS means use hadoop deps from doris-thirdparty.
# the hadoop deps from doris-thirdparty contains some modification diff from the standard hadoop, such as log interface
add_definitions(-DUSE_DORIS_HADOOP_HDFS)
else()
add_library(hdfs3 STATIC IMPORTED)
set_target_properties(hdfs3 PROPERTIES IMPORTED_LOCATION ${THIRDPARTY_DIR}/lib/libhdfs3.a)
Expand Down
3 changes: 2 additions & 1 deletion be/src/common/config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1140,8 +1140,9 @@ DEFINE_Int32(rocksdb_max_write_buffer_number, "5");

DEFINE_mBool(allow_zero_date, "false");
DEFINE_Bool(allow_invalid_decimalv2_literal, "false");
DEFINE_mString(kerberos_ccache_path, "");
DEFINE_mString(kerberos_ccache_path, "/tmp/");
DEFINE_mString(kerberos_krb5_conf_path, "/etc/krb5.conf");
DEFINE_mInt32(kerberos_refresh_interval_second, "3600");

DEFINE_mString(get_stack_trace_tool, "libunwind");
DEFINE_mString(dwarf_location_info_mode, "FAST");
Expand Down
2 changes: 2 additions & 0 deletions be/src/common/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -1195,6 +1195,8 @@ DECLARE_mBool(allow_invalid_decimalv2_literal);
DECLARE_mString(kerberos_ccache_path);
// set krb5.conf path, use "/etc/krb5.conf" by default
DECLARE_mString(kerberos_krb5_conf_path);
// the interval for renew kerberos ticket cache
DECLARE_mInt32(kerberos_refresh_interval_second);

// Values include `none`, `glog`, `boost`, `glibc`, `libunwind`
DECLARE_mString(get_stack_trace_tool);
Expand Down
45 changes: 45 additions & 0 deletions be/src/common/kerberos/kerberos_config.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

#include "common/kerberos/kerberos_config.h"

#include <filesystem>

#include "common/config.h"
#include "util/md5.h"

namespace doris::kerberos {

KerberosConfig::KerberosConfig()
: _refresh_interval_second(3600), _min_time_before_refresh_second(600) {}

std::string KerberosConfig::get_hash_code(const std::string& principal, const std::string& keytab) {
return _get_hash_code(principal, keytab);
}

std::string KerberosConfig::_get_hash_code(const std::string& principal,
const std::string& keytab) {
// use md5(principal + keytab) as hash code
// so that same (principal + keytab) will have same name.
std::string combined = principal + keytab;
Md5Digest digest;
digest.update(combined.c_str(), combined.length());
digest.digest();
return digest.hex();
}

} // namespace doris::kerberos
77 changes: 77 additions & 0 deletions be/src/common/kerberos/kerberos_config.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

#pragma once

#include <chrono>
#include <string>

#include "common/status.h"

namespace doris::kerberos {

// Configuration class for Kerberos authentication
class KerberosConfig {
public:
// Constructor with default values for refresh intervals
KerberosConfig();

// Set the Kerberos principal and keytab file path
void set_principal_and_keytab(const std::string& principal, const std::string& keytab) {
_principal = principal;
_keytab_path = keytab;
}
// Set the path to krb5.conf configuration file
void set_krb5_conf_path(const std::string& path) { _krb5_conf_path = path; }
// Set the interval for refreshing Kerberos tickets (in seconds)
void set_refresh_interval(int32_t interval) { _refresh_interval_second = interval; }
// Set the minimum time before refreshing tickets (in seconds)
void set_min_time_before_refresh(int32_t time) { _min_time_before_refresh_second = time; }

// Get the Kerberos principal name
const std::string& get_principal() const { return _principal; }
// Get the path to the keytab file
const std::string& get_keytab_path() const { return _keytab_path; }
// Get the path to krb5.conf configuration file
const std::string& get_krb5_conf_path() const { return _krb5_conf_path; }
// Get the ticket refresh interval in seconds
int32_t get_refresh_interval_second() const { return _refresh_interval_second; }
// Get the minimum time before refresh in seconds
int32_t get_min_time_before_refresh_second() const { return _min_time_before_refresh_second; }

std::string get_hash_code() const { return _get_hash_code(_principal, _keytab_path); }

// Use principal and keytab to generate a hash code.
static std::string get_hash_code(const std::string& principal, const std::string& keytab);

private:
static std::string _get_hash_code(const std::string& principal, const std::string& keytab);

private:
// Kerberos principal name (e.g., "[email protected]")
std::string _principal;
// Path to the Kerberos keytab file
std::string _keytab_path;
// Path to the Kerberos configuration file (krb5.conf)
std::string _krb5_conf_path;
// Interval for refreshing Kerberos tickets (in seconds)
int32_t _refresh_interval_second;
// Minimum time before refreshing tickets (in seconds)
int32_t _min_time_before_refresh_second;
};

} // namespace doris::kerberos
Loading
Loading