Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](p0) don't run move-memtable injection cases in cloud mode #47311

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Jan 22, 2025

What problem does this PR solve?

Issue Number: DORIS-18364

Problem Summary:

The fault injections are for memtable_on_sink_node, which is not supported in cloud mode yet.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Sorry, something went wrong.

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Contributor Author

run buildall

@kaijchen kaijchen changed the title [test](p0) don't run test_multi_replica_fault_injection in cloud mode [test](p0) don't run move-memtable injection cases in cloud mode Jan 24, 2025
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 24, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@kaijchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f45984b into apache:master Jan 27, 2025
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
)

The fault injections are for memtable_on_sink_node, which is not
supported in cloud mode yet.
dataroaring pushed a commit that referenced this pull request Jan 29, 2025
…ud mode #47311 (#47468)

Cherry-picked from #47311

Co-authored-by: Kaijie Chen <[email protected]>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
…che#47311)

The fault injections are for memtable_on_sink_node, which is not
supported in cloud mode yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants