Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enchement](schema change)Standardize the behavior after a table schema change. #47471

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hubgeter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32452 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab18b648d01d76fb37d32b67a059025f92f6ccd1, data reload: false

------ Round 1 ----------------------------------
q1	17575	5967	5409	5409
q2	2044	301	168	168
q3	10436	1272	741	741
q4	10230	977	526	526
q5	8039	2365	2141	2141
q6	200	162	132	132
q7	908	769	593	593
q8	9236	1360	1149	1149
q9	5225	4924	4939	4924
q10	6837	2334	1908	1908
q11	484	273	263	263
q12	351	352	221	221
q13	17925	3863	3236	3236
q14	234	237	206	206
q15	515	494	468	468
q16	633	615	601	601
q17	602	889	353	353
q18	7118	6365	6295	6295
q19	1791	956	549	549
q20	307	313	202	202
q21	2900	2271	2057	2057
q22	370	339	310	310
Total cold run time: 103960 ms
Total hot run time: 32452 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5573	5500	5522	5500
q2	235	327	238	238
q3	2312	2683	2316	2316
q4	1482	1825	1401	1401
q5	4382	4744	4746	4744
q6	176	166	132	132
q7	2041	1990	1878	1878
q8	2633	2842	2731	2731
q9	7216	7243	7229	7229
q10	3046	3313	2776	2776
q11	575	511	475	475
q12	633	722	635	635
q13	3535	4010	3328	3328
q14	295	296	269	269
q15	527	476	471	471
q16	660	679	651	651
q17	1259	1752	1259	1259
q18	7787	7536	7223	7223
q19	793	1184	1082	1082
q20	2011	2031	1911	1911
q21	5868	5125	5023	5023
q22	597	634	595	595
Total cold run time: 53636 ms
Total hot run time: 51867 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192144 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab18b648d01d76fb37d32b67a059025f92f6ccd1, data reload: false

query1	1348	971	933	933
query2	6297	1950	2078	1950
query3	10999	4511	4517	4511
query4	60844	28622	22925	22925
query5	5555	598	450	450
query6	442	208	187	187
query7	5547	508	303	303
query8	330	239	231	231
query9	8419	2719	2703	2703
query10	443	312	251	251
query11	17922	15135	15554	15135
query12	153	107	110	107
query13	1454	561	403	403
query14	11469	7501	7276	7276
query15	216	207	194	194
query16	7275	658	514	514
query17	1156	758	599	599
query18	1935	410	327	327
query19	206	191	173	173
query20	126	117	110	110
query21	210	125	108	108
query22	4586	4706	4614	4614
query23	34069	33333	33462	33333
query24	5459	2383	2398	2383
query25	479	509	390	390
query26	673	278	166	166
query27	1913	469	332	332
query28	4264	2505	2504	2504
query29	572	571	422	422
query30	208	187	152	152
query31	934	877	832	832
query32	67	62	60	60
query33	426	354	308	308
query34	730	883	529	529
query35	834	833	759	759
query36	1012	1065	982	982
query37	121	107	74	74
query38	4454	4308	4367	4308
query39	1502	1467	1429	1429
query40	201	121	106	106
query41	50	52	48	48
query42	118	105	102	102
query43	523	524	507	507
query44	1353	864	855	855
query45	182	181	173	173
query46	904	1074	660	660
query47	1873	1930	1866	1866
query48	388	414	325	325
query49	726	520	427	427
query50	663	677	410	410
query51	4339	4305	4273	4273
query52	105	102	96	96
query53	229	266	193	193
query54	489	516	410	410
query55	83	78	85	78
query56	274	265	255	255
query57	1201	1230	1159	1159
query58	237	235	237	235
query59	3261	3368	3075	3075
query60	268	263	250	250
query61	115	113	109	109
query62	723	722	647	647
query63	226	197	190	190
query64	1288	1001	691	691
query65	3243	3144	3127	3127
query66	760	391	290	290
query67	16016	15798	15275	15275
query68	5001	831	533	533
query69	480	296	255	255
query70	1210	1151	1129	1129
query71	392	275	302	275
query72	6110	3891	3751	3751
query73	767	751	368	368
query74	9758	9153	8765	8765
query75	3207	3184	2705	2705
query76	3793	1156	759	759
query77	469	353	279	279
query78	10070	10070	9400	9400
query79	2325	847	618	618
query80	687	510	464	464
query81	516	279	237	237
query82	292	150	120	120
query83	172	176	147	147
query84	288	94	76	76
query85	729	365	302	302
query86	349	320	297	297
query87	4638	4453	4406	4406
query88	3218	2215	2266	2215
query89	402	324	307	307
query90	1611	193	188	188
query91	135	133	110	110
query92	59	54	52	52
query93	1843	872	541	541
query94	655	414	305	305
query95	334	264	247	247
query96	496	623	280	280
query97	2820	2891	2766	2766
query98	225	203	199	199
query99	1302	1342	1249	1249
Total cold run time: 308840 ms
Total hot run time: 192144 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.49 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab18b648d01d76fb37d32b67a059025f92f6ccd1, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.44	0.41	0.38
query6	1.17	0.65	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.60	0.49	0.49
query10	0.56	0.58	0.56
query11	0.15	0.10	0.11
query12	0.13	0.10	0.11
query13	0.62	0.60	0.60
query14	2.72	2.78	2.74
query15	0.88	0.82	0.82
query16	0.38	0.39	0.38
query17	1.01	1.05	0.98
query18	0.24	0.21	0.19
query19	1.96	1.86	1.99
query20	0.01	0.01	0.01
query21	15.39	0.93	0.58
query22	0.77	0.79	0.73
query23	15.19	1.43	0.62
query24	4.48	0.77	0.96
query25	0.19	0.11	0.10
query26	0.33	0.16	0.14
query27	0.05	0.07	0.04
query28	13.47	1.00	0.43
query29	12.60	3.88	3.28
query30	0.25	0.08	0.06
query31	2.84	0.58	0.39
query32	3.23	0.54	0.46
query33	2.96	3.06	3.02
query34	16.30	5.13	4.49
query35	4.48	4.48	4.46
query36	0.65	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.15	0.12	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 106.54 s
Total hot run time: 30.49 s

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32539 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 99ccfa2ec3c5dbae8c4c2da779d408a9c5839fd2, data reload: false

------ Round 1 ----------------------------------
q1	17575	5473	5405	5405
q2	2052	301	162	162
q3	10448	1235	763	763
q4	10220	970	535	535
q5	7665	2357	2168	2168
q6	191	174	132	132
q7	905	755	622	622
q8	9222	1342	1144	1144
q9	5171	4870	4887	4870
q10	6838	2318	1926	1926
q11	467	282	259	259
q12	337	359	225	225
q13	17758	3704	3078	3078
q14	232	229	212	212
q15	526	481	460	460
q16	631	614	597	597
q17	555	866	317	317
q18	6932	6598	6568	6568
q19	2520	984	562	562
q20	309	331	204	204
q21	2960	2180	2021	2021
q22	360	340	309	309
Total cold run time: 103874 ms
Total hot run time: 32539 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5615	5450	5516	5450
q2	244	323	230	230
q3	2293	2641	2353	2353
q4	1433	1827	1379	1379
q5	4339	4729	4580	4580
q6	163	155	131	131
q7	2075	1985	1866	1866
q8	2636	2838	2671	2671
q9	7315	7300	7243	7243
q10	3011	3309	2796	2796
q11	578	510	497	497
q12	667	746	584	584
q13	3534	3956	3304	3304
q14	290	290	285	285
q15	516	473	470	470
q16	662	684	656	656
q17	1231	1719	1297	1297
q18	7723	7404	7153	7153
q19	803	1087	1147	1087
q20	2005	2047	1868	1868
q21	5825	5249	4822	4822
q22	591	583	556	556
Total cold run time: 53549 ms
Total hot run time: 51278 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192302 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 99ccfa2ec3c5dbae8c4c2da779d408a9c5839fd2, data reload: false

query1	1321	922	928	922
query2	6207	2122	2088	2088
query3	10999	4595	4467	4467
query4	32713	23329	23514	23329
query5	3849	611	463	463
query6	295	202	186	186
query7	3992	489	308	308
query8	299	255	235	235
query9	9501	2654	2661	2654
query10	455	306	259	259
query11	17516	15088	15002	15002
query12	158	107	103	103
query13	1557	519	385	385
query14	8673	7091	7096	7091
query15	255	210	193	193
query16	7750	624	477	477
query17	1617	711	596	596
query18	2068	425	345	345
query19	224	195	165	165
query20	125	117	120	117
query21	224	129	116	116
query22	4588	4707	4184	4184
query23	34224	33828	33242	33242
query24	6409	2349	2325	2325
query25	490	496	432	432
query26	801	279	166	166
query27	2111	468	347	347
query28	5333	2508	2472	2472
query29	580	601	433	433
query30	216	197	169	169
query31	919	899	804	804
query32	80	67	59	59
query33	497	363	329	329
query34	745	883	528	528
query35	822	833	747	747
query36	1008	1046	985	985
query37	128	98	85	85
query38	4347	4302	4276	4276
query39	1717	1425	1423	1423
query40	221	118	106	106
query41	54	53	52	52
query42	120	109	107	107
query43	541	549	521	521
query44	1387	823	824	823
query45	194	172	171	171
query46	895	1051	652	652
query47	1874	1891	1823	1823
query48	390	424	326	326
query49	733	530	405	405
query50	675	678	408	408
query51	4371	4271	4241	4241
query52	117	112	103	103
query53	237	255	206	206
query54	513	512	426	426
query55	89	80	77	77
query56	275	270	245	245
query57	1189	1175	1143	1143
query58	257	232	228	228
query59	3337	3436	3355	3355
query60	287	281	252	252
query61	120	121	127	121
query62	812	755	678	678
query63	230	203	195	195
query64	3659	1039	706	706
query65	3398	3265	3249	3249
query66	878	410	306	306
query67	16219	15549	15370	15370
query68	5434	828	546	546
query69	498	298	260	260
query70	1190	1154	1087	1087
query71	374	293	256	256
query72	5906	3837	3916	3837
query73	669	759	363	363
query74	10349	9104	9059	9059
query75	3179	3155	2670	2670
query76	3095	1242	783	783
query77	464	372	278	278
query78	10037	10203	9364	9364
query79	2771	841	605	605
query80	1359	543	458	458
query81	546	270	234	234
query82	348	151	120	120
query83	172	168	155	155
query84	242	91	78	78
query85	734	350	303	303
query86	404	309	304	304
query87	4532	4508	4317	4317
query88	4383	2177	2122	2122
query89	382	326	291	291
query90	1804	190	198	190
query91	135	138	118	118
query92	67	55	54	54
query93	2642	878	534	534
query94	730	401	307	307
query95	329	275	261	261
query96	494	619	278	278
query97	2770	2818	2813	2813
query98	225	207	204	204
query99	1326	1379	1251	1251
Total cold run time: 285475 ms
Total hot run time: 192302 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.05 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 99ccfa2ec3c5dbae8c4c2da779d408a9c5839fd2, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.42	0.40	0.41
query6	1.13	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.55	0.56	0.54
query11	0.14	0.10	0.11
query12	0.14	0.10	0.10
query13	0.60	0.60	0.60
query14	2.75	2.78	2.88
query15	0.89	0.83	0.86
query16	0.39	0.38	0.38
query17	1.06	0.99	1.03
query18	0.23	0.20	0.20
query19	1.88	1.88	1.99
query20	0.01	0.01	0.01
query21	15.35	0.92	0.58
query22	0.75	0.85	0.72
query23	15.26	1.48	0.51
query24	2.61	1.29	1.31
query25	0.17	0.23	0.07
query26	0.27	0.15	0.14
query27	0.08	0.05	0.05
query28	14.06	1.04	0.44
query29	12.62	3.90	3.22
query30	0.25	0.09	0.07
query31	2.80	0.59	0.40
query32	3.22	0.55	0.46
query33	2.98	3.05	3.13
query34	16.76	5.08	4.56
query35	4.56	4.53	4.47
query36	0.64	0.50	0.48
query37	0.10	0.06	0.05
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.67 s
Total hot run time: 31.05 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.07% (10997/26138)
Line Coverage: 32.33% (92880/287262)
Region Coverage: 31.50% (47643/151248)
Branch Coverage: 27.56% (24122/87512)
Coverage Report: http://coverage.selectdb-in.cc/coverage/99ccfa2ec3c5dbae8c4c2da779d408a9c5839fd2_99ccfa2ec3c5dbae8c4c2da779d408a9c5839fd2/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants