-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](inverted index) Add profile statistics for each condition in inverted index filters #47504
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
c75c6d0
to
b35d749
Compare
run buildall |
TPC-H: Total hot run time: 32210 ms
|
TPC-DS: Total hot run time: 193009 ms
|
ClickBench: Total hot run time: 30.25 s
|
TeamCity be ut coverage result: |
run buildall |
TPC-H: Total hot run time: 32686 ms
|
TPC-DS: Total hot run time: 186506 ms
|
ClickBench: Total hot run time: 30.65 s
|
TeamCity be ut coverage result: |
b35d749
to
221058f
Compare
run buildall |
TPC-H: Total hot run time: 31459 ms
|
TPC-DS: Total hot run time: 184440 ms
|
ClickBench: Total hot run time: 30.46 s
|
…n inverted index filters
221058f
to
a1cd6dc
Compare
run buildall |
TPC-H: Total hot run time: 31645 ms
|
TPC-DS: Total hot run time: 190603 ms
|
ClickBench: Total hot run time: 30.89 s
|
TeamCity be ut coverage result: |
for (auto stats : statistics->stats) { | ||
ADD_TIMER_WITH_LEVEL(profile, filter_rows_name, 1); | ||
auto* filter_rows = ADD_CHILD_COUNTER_WITH_LEVEL(profile, "fr_" + stats.column_name, | ||
TUnit::UNIT, filter_rows_name, 1); | ||
COUNTER_UPDATE(filter_rows, stats.filter_rows); | ||
} | ||
|
||
for (auto stats : statistics->stats) { | ||
ADD_TIMER_WITH_LEVEL(profile, filter_time_name, 1); | ||
auto* filter_time = ADD_CHILD_COUNTER_WITH_LEVEL(profile, "ft_" + stats.column_name, | ||
TUnit::TIME_NS, filter_time_name, 1); | ||
COUNTER_UPDATE(filter_time, stats.filter_time); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge two loops into one?
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
select count() from httplogs where clientip match '232.71.0.0' and request match 'images';
IndexFilter:
- FilteredRows: 0ns
- fr_clientip: 10.392K (10392)
- fr_request: 28.601172M (28601172)
- FilteredTime: 0ns
- ft_clientip: 2.65ms
- ft_request: 201.778ms
FilteredRows: Represents the count of rows that met the filtering conditions post-index filtering.
FilteredTime: Represents the time taken to complete the filtering operation.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)