-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](binlog) Speed binlog gc by locked binlogs #47547
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32413 ms
|
TPC-DS: Total hot run time: 189694 ms
|
ClickBench: Total hot run time: 30.59 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #46887, https://github.com/selectdb/ccr-syncer/pull/399/files
Problem Summary:
This is the second PR for locking binlogs.
To reduce the cost of maintaining binlogs, an API named lockBinlog has
been added. Users use this API to indicate which binlogs are not
permitted for GC.
The binlog gcer will recycle all binlogs until the locked one. However, in order to remain compatible with the old behaviors, if no binlog is locked here, it falls through to the previous behavior (keep the entire binlogs until they are expired)
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)