Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](binlog) Save properties in CreateTableRecord #47551

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Feb 6, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Feb 6, 2025

run buildall

1 similar comment
@w41ter
Copy link
Contributor Author

w41ter commented Feb 6, 2025

run buildall

@w41ter w41ter force-pushed the improve_create_table_record branch from b5b3999 to accd7b5 Compare February 7, 2025 02:04
@w41ter
Copy link
Contributor Author

w41ter commented Feb 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31153 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit accd7b5dbfcb5de7a37f4d3596ce5f812f35f3e8, data reload: false

------ Round 1 ----------------------------------
q1	17579	5125	5080	5080
q2	2041	301	170	170
q3	10418	1240	736	736
q4	10213	999	521	521
q5	7502	2386	2277	2277
q6	182	166	128	128
q7	878	749	586	586
q8	9300	1244	1057	1057
q9	4874	4553	4931	4553
q10	6835	2304	1863	1863
q11	488	275	254	254
q12	340	350	215	215
q13	17773	3613	3106	3106
q14	233	237	208	208
q15	535	465	477	465
q16	644	624	579	579
q17	550	851	338	338
q18	6690	6100	6172	6100
q19	1220	924	516	516
q20	298	327	198	198
q21	2744	2122	1906	1906
q22	364	329	297	297
Total cold run time: 101701 ms
Total hot run time: 31153 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5163	5166	5103	5103
q2	243	330	229	229
q3	2271	2728	2369	2369
q4	1447	1835	1435	1435
q5	4295	4170	4131	4131
q6	202	164	126	126
q7	1866	1841	1668	1668
q8	2565	2585	2485	2485
q9	7202	7184	7127	7127
q10	3025	3225	2813	2813
q11	579	521	515	515
q12	693	781	642	642
q13	3482	3835	3213	3213
q14	288	285	272	272
q15	531	467	455	455
q16	645	692	658	658
q17	1115	1620	1275	1275
q18	7629	7356	7289	7289
q19	764	761	781	761
q20	1969	2065	1834	1834
q21	5363	4960	4748	4748
q22	618	569	536	536
Total cold run time: 51955 ms
Total hot run time: 49684 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190177 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit accd7b5dbfcb5de7a37f4d3596ce5f812f35f3e8, data reload: false

query1	1345	988	931	931
query2	6211	1877	1881	1877
query3	11089	4597	4621	4597
query4	55244	23998	23415	23415
query5	5257	545	467	467
query6	343	202	186	186
query7	4906	509	295	295
query8	314	247	230	230
query9	6048	2519	2517	2517
query10	414	313	269	269
query11	15082	14961	14861	14861
query12	165	111	115	111
query13	1052	509	396	396
query14	10585	6714	6294	6294
query15	210	199	183	183
query16	7005	649	469	469
query17	1025	714	560	560
query18	1562	422	303	303
query19	191	204	170	170
query20	130	125	134	125
query21	209	128	101	101
query22	4553	4653	4413	4413
query23	33871	33453	33190	33190
query24	5698	2405	2437	2405
query25	466	475	401	401
query26	757	280	163	163
query27	1942	508	335	335
query28	3080	2413	2436	2413
query29	586	584	438	438
query30	212	196	163	163
query31	847	881	797	797
query32	76	61	60	60
query33	461	369	294	294
query34	769	883	521	521
query35	840	846	742	742
query36	995	1003	923	923
query37	133	108	86	86
query38	4400	4403	4228	4228
query39	1491	1483	1441	1441
query40	218	117	106	106
query41	50	50	57	50
query42	125	106	108	106
query43	484	524	499	499
query44	1298	794	810	794
query45	181	173	167	167
query46	887	1075	661	661
query47	1903	1865	1783	1783
query48	379	409	311	311
query49	697	538	439	439
query50	715	755	437	437
query51	4271	4269	4214	4214
query52	106	112	98	98
query53	233	260	196	196
query54	487	498	409	409
query55	89	82	78	78
query56	274	277	270	270
query57	1173	1177	1141	1141
query58	256	262	255	255
query59	2729	2927	2932	2927
query60	276	268	277	268
query61	127	114	116	114
query62	734	761	704	704
query63	235	192	195	192
query64	2042	1038	676	676
query65	3282	3162	3129	3129
query66	763	386	297	297
query67	15952	15639	15464	15464
query68	5702	782	524	524
query69	523	308	264	264
query70	1227	1135	1114	1114
query71	457	309	275	275
query72	6307	3688	3810	3688
query73	1288	758	351	351
query74	9234	9085	8706	8706
query75	3196	3140	2663	2663
query76	3944	1177	738	738
query77	548	399	272	272
query78	10051	10054	9347	9347
query79	2365	800	583	583
query80	607	517	438	438
query81	515	282	240	240
query82	482	156	120	120
query83	175	167	151	151
query84	292	87	70	70
query85	822	353	321	321
query86	387	295	267	267
query87	4460	4636	4394	4394
query88	3596	2178	2160	2160
query89	413	322	285	285
query90	1742	195	190	190
query91	137	138	109	109
query92	73	59	60	59
query93	1906	1007	592	592
query94	701	419	316	316
query95	346	273	255	255
query96	472	586	271	271
query97	2814	2856	2780	2780
query98	232	215	206	206
query99	1346	1412	1273	1273
Total cold run time: 295890 ms
Total hot run time: 190177 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit accd7b5dbfcb5de7a37f4d3596ce5f812f35f3e8, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.42	0.38
query6	1.18	0.66	0.67
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.52
query10	0.59	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.10
query13	0.62	0.59	0.60
query14	2.72	2.82	2.72
query15	0.92	0.84	0.85
query16	0.38	0.37	0.38
query17	1.03	1.04	1.04
query18	0.22	0.20	0.19
query19	1.91	1.78	1.99
query20	0.01	0.01	0.01
query21	15.37	0.91	0.55
query22	0.75	1.09	0.60
query23	15.12	1.42	0.62
query24	7.68	1.45	0.78
query25	0.48	0.18	0.18
query26	0.60	0.17	0.13
query27	0.05	0.05	0.05
query28	9.31	0.85	0.42
query29	12.57	3.99	3.31
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.22	0.55	0.48
query33	2.99	3.03	3.06
query34	15.74	5.17	4.52
query35	4.58	4.54	4.57
query36	0.65	0.49	0.48
query37	0.10	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 105.57 s
Total hot run time: 30.59 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants