Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](macOS) Fix unnecessary installation of thirdparty libs in Darwin #47572

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Feb 7, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

introduced by #47438. checked non-existent lib in Darwin. now fix it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31628 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 034a8fda6f61ce36bdb20859eb6bfd21963913ff, data reload: false

------ Round 1 ----------------------------------
q1	17607	5177	5099	5099
q2	2053	304	173	173
q3	10425	1362	712	712
q4	10221	1030	553	553
q5	7579	2390	2363	2363
q6	189	162	134	134
q7	917	768	611	611
q8	9322	1301	1037	1037
q9	5070	4693	4886	4693
q10	6830	2334	1875	1875
q11	467	280	267	267
q12	366	356	220	220
q13	17769	3701	3084	3084
q14	236	226	206	206
q15	512	470	461	461
q16	618	628	571	571
q17	568	869	336	336
q18	6950	6367	6211	6211
q19	1618	945	542	542
q20	310	318	199	199
q21	2804	2258	1973	1973
q22	363	328	308	308
Total cold run time: 102794 ms
Total hot run time: 31628 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5137	5138	5112	5112
q2	248	328	229	229
q3	2190	2655	2350	2350
q4	1445	1879	1399	1399
q5	4248	4164	4190	4164
q6	213	163	121	121
q7	1874	1819	1803	1803
q8	2647	2693	2628	2628
q9	7204	7129	7052	7052
q10	3033	3220	2788	2788
q11	581	525	493	493
q12	694	757	654	654
q13	3566	3908	3259	3259
q14	275	282	286	282
q15	510	457	467	457
q16	659	685	644	644
q17	1115	1551	1342	1342
q18	7546	7436	7262	7262
q19	798	822	1114	822
q20	1941	2022	1873	1873
q21	5429	5048	4946	4946
q22	614	601	546	546
Total cold run time: 51967 ms
Total hot run time: 50226 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183289 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 034a8fda6f61ce36bdb20859eb6bfd21963913ff, data reload: false

query1	986	383	387	383
query2	6528	1950	1910	1910
query3	6794	215	215	215
query4	26343	23663	23167	23167
query5	4338	661	477	477
query6	290	183	204	183
query7	4602	500	307	307
query8	292	250	246	246
query9	8631	2504	2498	2498
query10	473	331	265	265
query11	15547	15061	14945	14945
query12	160	108	110	108
query13	1658	524	398	398
query14	9025	6943	6258	6258
query15	224	198	180	180
query16	7447	640	493	493
query17	1211	714	570	570
query18	1955	398	307	307
query19	193	194	158	158
query20	123	120	119	119
query21	208	122	112	112
query22	4252	4266	4509	4266
query23	34281	33435	32907	32907
query24	7700	2393	2373	2373
query25	547	444	370	370
query26	1265	266	151	151
query27	2157	490	317	317
query28	3946	2374	2367	2367
query29	748	536	413	413
query30	229	186	153	153
query31	924	840	775	775
query32	75	66	64	64
query33	543	361	294	294
query34	786	843	509	509
query35	774	802	765	765
query36	958	986	883	883
query37	116	99	86	86
query38	4102	4266	4223	4223
query39	1444	1396	1384	1384
query40	209	112	98	98
query41	64	56	49	49
query42	125	104	103	103
query43	499	509	477	477
query44	1258	774	791	774
query45	186	167	164	164
query46	861	1020	661	661
query47	1762	1784	1698	1698
query48	368	407	319	319
query49	776	483	402	402
query50	667	719	407	407
query51	4149	4173	4113	4113
query52	104	108	102	102
query53	230	252	189	189
query54	480	485	426	426
query55	83	81	77	77
query56	272	262	250	250
query57	1128	1136	1079	1079
query58	240	232	253	232
query59	2713	2808	2463	2463
query60	279	277	250	250
query61	115	147	111	111
query62	798	709	642	642
query63	223	183	188	183
query64	4359	974	644	644
query65	3213	3132	3142	3132
query66	1126	406	297	297
query67	16027	15684	15620	15620
query68	6462	765	512	512
query69	497	307	281	281
query70	1168	1155	1046	1046
query71	434	280	270	270
query72	5744	3614	3742	3614
query73	737	734	348	348
query74	8831	9116	8585	8585
query75	3142	3162	2680	2680
query76	3287	1172	731	731
query77	456	399	280	280
query78	9980	10037	9245	9245
query79	2397	805	597	597
query80	651	520	450	450
query81	513	273	245	245
query82	219	148	117	117
query83	173	165	153	153
query84	247	155	70	70
query85	743	342	299	299
query86	385	296	291	291
query87	4408	4526	4440	4440
query88	4040	2157	2155	2155
query89	397	323	292	292
query90	1985	194	186	186
query91	133	135	118	118
query92	77	62	60	60
query93	1933	999	586	586
query94	695	399	302	302
query95	421	266	255	255
query96	465	566	274	274
query97	2744	2885	2757	2757
query98	221	211	203	203
query99	1327	1412	1286	1286
Total cold run time: 269101 ms
Total hot run time: 183289 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 034a8fda6f61ce36bdb20859eb6bfd21963913ff, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.43	0.42	0.41
query6	1.14	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.59	0.52	0.52
query10	0.58	0.59	0.57
query11	0.15	0.10	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.67	2.82	2.73
query15	0.92	0.86	0.86
query16	0.38	0.39	0.38
query17	1.05	1.06	1.07
query18	0.21	0.20	0.19
query19	1.94	1.86	2.03
query20	0.02	0.00	0.02
query21	15.35	0.90	0.55
query22	0.76	1.21	0.73
query23	14.82	1.40	0.62
query24	7.00	1.67	0.35
query25	0.39	0.21	0.13
query26	0.65	0.16	0.14
query27	0.05	0.04	0.05
query28	10.02	0.88	0.42
query29	12.54	3.98	3.31
query30	0.24	0.09	0.06
query31	2.82	0.59	0.39
query32	3.22	0.56	0.45
query33	3.00	3.04	3.02
query34	15.91	5.15	4.54
query35	4.55	4.55	4.56
query36	0.65	0.50	0.48
query37	0.09	0.06	0.07
query38	0.06	0.05	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.32 s
Total hot run time: 30.4 s

Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit c04c9c0 into apache:master Feb 7, 2025
29 of 30 checks passed
@zclllyybb zclllyybb deleted the fix_mac_third branch February 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants