Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](partition) Forbid modify storage_policy of partitions in synced table #47576

Closed
wants to merge 1 commit into from

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Feb 7, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Feb 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31822 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 821ef762883250b035a31be1ffd8b42f7d24173f, data reload: false

------ Round 1 ----------------------------------
q1	17582	5255	5137	5137
q2	2053	309	186	186
q3	10382	1266	759	759
q4	10211	1019	545	545
q5	7570	2408	2393	2393
q6	179	163	130	130
q7	914	759	605	605
q8	9314	1373	1130	1130
q9	4959	4926	4694	4694
q10	6848	2307	1913	1913
q11	509	277	256	256
q12	348	360	224	224
q13	17771	3743	3069	3069
q14	230	240	209	209
q15	516	485	465	465
q16	623	621	603	603
q17	591	891	344	344
q18	6709	6263	6182	6182
q19	1906	966	549	549
q20	303	335	189	189
q21	2870	2118	1934	1934
q22	366	339	306	306
Total cold run time: 102754 ms
Total hot run time: 31822 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5243	5152	5159	5152
q2	240	327	227	227
q3	2188	2727	2343	2343
q4	1484	1908	1411	1411
q5	4280	4161	4193	4161
q6	211	163	124	124
q7	1875	1872	1763	1763
q8	2667	2659	2594	2594
q9	7291	7184	7217	7184
q10	3044	3219	2823	2823
q11	578	516	503	503
q12	742	811	682	682
q13	3374	3944	3360	3360
q14	274	284	269	269
q15	510	456	471	456
q16	651	680	662	662
q17	1172	1670	1302	1302
q18	7529	7287	7245	7245
q19	842	804	848	804
q20	1966	2030	1905	1905
q21	5595	5287	4754	4754
q22	650	560	578	560
Total cold run time: 52406 ms
Total hot run time: 50284 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192468 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 821ef762883250b035a31be1ffd8b42f7d24173f, data reload: false

query1	1304	971	933	933
query2	6248	1845	1824	1824
query3	11123	4694	4545	4545
query4	56247	25429	23476	23476
query5	5059	557	486	486
query6	328	206	181	181
query7	4886	518	297	297
query8	315	254	233	233
query9	5448	2529	2546	2529
query10	419	316	257	257
query11	15093	15157	15190	15157
query12	169	112	112	112
query13	1042	533	398	398
query14	10231	6931	7020	6931
query15	221	193	184	184
query16	7094	673	506	506
query17	1082	745	607	607
query18	1662	438	336	336
query19	210	202	168	168
query20	130	123	121	121
query21	217	130	110	110
query22	4522	4437	4539	4437
query23	34205	33466	33554	33466
query24	5703	2483	2505	2483
query25	478	473	419	419
query26	726	280	163	163
query27	1841	502	336	336
query28	2721	2488	2438	2438
query29	590	584	425	425
query30	215	190	158	158
query31	933	900	820	820
query32	73	65	63	63
query33	450	371	334	334
query34	786	868	504	504
query35	813	852	780	780
query36	982	1024	896	896
query37	128	99	83	83
query38	4301	4534	4356	4356
query39	1663	1490	1469	1469
query40	217	117	107	107
query41	51	55	52	52
query42	123	105	122	105
query43	501	506	498	498
query44	1362	823	802	802
query45	182	182	174	174
query46	901	1100	672	672
query47	1857	1908	1818	1818
query48	383	427	294	294
query49	690	531	465	465
query50	715	770	424	424
query51	4292	4326	4241	4241
query52	113	110	102	102
query53	244	305	191	191
query54	507	524	428	428
query55	84	83	80	80
query56	277	278	269	269
query57	1201	1179	1110	1110
query58	261	250	253	250
query59	2728	2805	2647	2647
query60	312	302	269	269
query61	126	122	123	122
query62	811	768	707	707
query63	241	200	196	196
query64	1848	1061	720	720
query65	3293	3277	3150	3150
query66	749	399	302	302
query67	15933	15605	15562	15562
query68	5540	793	520	520
query69	521	299	269	269
query70	1237	1154	1132	1132
query71	471	301	277	277
query72	6286	3731	3806	3731
query73	1434	754	348	348
query74	8978	9223	9113	9113
query75	3270	3160	2691	2691
query76	3834	1184	766	766
query77	559	438	289	289
query78	10106	10256	9315	9315
query79	2284	815	586	586
query80	657	542	450	450
query81	513	285	242	242
query82	340	151	119	119
query83	179	167	149	149
query84	285	92	71	71
query85	733	349	316	316
query86	365	306	281	281
query87	4553	4521	4567	4521
query88	3277	2188	2148	2148
query89	398	331	290	290
query90	1871	195	191	191
query91	136	144	112	112
query92	71	68	62	62
query93	2514	1025	581	581
query94	669	416	308	308
query95	345	277	263	263
query96	482	569	275	275
query97	2760	2858	2766	2766
query98	232	203	210	203
query99	1322	1420	1305	1305
Total cold run time: 295882 ms
Total hot run time: 192468 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 821ef762883250b035a31be1ffd8b42f7d24173f, data reload: false

query1	0.03	0.05	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.42	0.42	0.41
query6	1.16	0.67	0.67
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.61	0.51	0.53
query10	0.59	0.59	0.57
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.62
query14	2.71	2.84	2.73
query15	0.93	0.85	0.86
query16	0.38	0.39	0.37
query17	1.03	1.04	1.03
query18	0.21	0.20	0.20
query19	1.95	1.85	2.00
query20	0.01	0.02	0.02
query21	15.39	0.88	0.57
query22	0.78	1.22	0.61
query23	15.00	1.42	0.63
query24	7.49	1.50	0.55
query25	0.50	0.17	0.07
query26	0.64	0.17	0.14
query27	0.05	0.06	0.05
query28	8.90	0.89	0.45
query29	12.62	4.03	3.30
query30	0.24	0.09	0.06
query31	2.85	0.62	0.39
query32	3.22	0.54	0.47
query33	3.01	3.00	3.09
query34	15.86	5.13	4.51
query35	4.62	4.53	4.59
query36	0.67	0.50	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.3 s
Total hot run time: 30.43 s

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Feb 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31704 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ce0eb2a3b60eff13756340f908383b026d88f45f, data reload: false

------ Round 1 ----------------------------------
q1	17565	5158	5078	5078
q2	2041	305	170	170
q3	10404	1238	742	742
q4	10235	1010	525	525
q5	7661	2413	2280	2280
q6	187	167	131	131
q7	903	772	595	595
q8	9272	1302	1066	1066
q9	4854	4705	4828	4705
q10	6833	2322	1898	1898
q11	473	267	260	260
q12	334	348	213	213
q13	17767	3632	3075	3075
q14	231	230	210	210
q15	515	463	461	461
q16	629	606	590	590
q17	564	872	356	356
q18	6866	6408	6468	6408
q19	1709	979	548	548
q20	308	326	193	193
q21	2779	2182	1905	1905
q22	348	323	295	295
Total cold run time: 102478 ms
Total hot run time: 31704 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5168	5072	5126	5072
q2	233	327	228	228
q3	2156	2669	2285	2285
q4	1484	1809	1408	1408
q5	4215	4118	4121	4118
q6	220	165	123	123
q7	1856	1805	1686	1686
q8	2596	2585	2519	2519
q9	7232	7226	7112	7112
q10	3035	3220	2816	2816
q11	564	519	482	482
q12	712	784	658	658
q13	3376	3856	3371	3371
q14	274	295	270	270
q15	507	466	461	461
q16	635	689	631	631
q17	1129	1612	1316	1316
q18	7579	7267	7362	7267
q19	792	820	883	820
q20	1944	1996	1909	1909
q21	5346	5022	4649	4649
q22	607	599	531	531
Total cold run time: 51660 ms
Total hot run time: 49732 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189817 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ce0eb2a3b60eff13756340f908383b026d88f45f, data reload: false

query1	1322	955	937	937
query2	6201	1819	1777	1777
query3	11112	4517	4583	4517
query4	53330	25197	23301	23301
query5	5299	591	504	504
query6	345	191	200	191
query7	4979	497	288	288
query8	314	245	229	229
query9	5964	2477	2487	2477
query10	370	316	255	255
query11	15109	15002	14797	14797
query12	155	108	109	108
query13	1060	507	363	363
query14	10183	6225	6660	6225
query15	200	208	181	181
query16	6934	648	503	503
query17	1091	728	606	606
query18	1524	436	311	311
query19	202	202	171	171
query20	132	126	129	126
query21	216	127	110	110
query22	4462	4653	4627	4627
query23	33779	33356	33377	33356
query24	5668	2403	2422	2403
query25	486	477	408	408
query26	785	289	146	146
query27	2128	457	342	342
query28	2934	2418	2400	2400
query29	600	584	437	437
query30	209	193	149	149
query31	888	892	794	794
query32	74	64	61	61
query33	463	378	319	319
query34	771	840	488	488
query35	796	824	763	763
query36	951	982	911	911
query37	120	102	79	79
query38	4278	4357	4317	4317
query39	1484	1450	1480	1450
query40	208	120	103	103
query41	49	48	80	48
query42	119	111	106	106
query43	514	519	474	474
query44	1311	792	790	790
query45	181	176	167	167
query46	883	1075	665	665
query47	1894	1904	1766	1766
query48	380	424	318	318
query49	697	509	412	412
query50	718	743	415	415
query51	4286	4389	4180	4180
query52	108	105	93	93
query53	240	260	184	184
query54	486	497	434	434
query55	85	82	84	82
query56	297	282	254	254
query57	1124	1222	1096	1096
query58	247	235	243	235
query59	2673	2790	2668	2668
query60	292	289	251	251
query61	113	111	114	111
query62	742	737	674	674
query63	231	186	187	186
query64	2060	1049	689	689
query65	3291	3161	3157	3157
query66	760	391	326	326
query67	15979	15595	15589	15589
query68	5295	771	516	516
query69	516	300	266	266
query70	1220	1116	1052	1052
query71	421	294	265	265
query72	6345	3646	3756	3646
query73	1279	758	346	346
query74	9215	9133	8946	8946
query75	3169	3131	2663	2663
query76	3855	1171	740	740
query77	560	358	272	272
query78	9900	10058	9355	9355
query79	2156	814	585	585
query80	656	524	460	460
query81	498	284	238	238
query82	222	150	117	117
query83	169	168	146	146
query84	291	85	68	68
query85	737	339	312	312
query86	358	304	288	288
query87	4381	4588	4347	4347
query88	2841	2219	2128	2128
query89	381	311	282	282
query90	1742	192	185	185
query91	146	140	108	108
query92	71	60	54	54
query93	2248	999	572	572
query94	682	403	305	305
query95	347	326	255	255
query96	481	560	263	263
query97	2799	2826	2686	2686
query98	225	211	188	188
query99	1287	1380	1263	1263
Total cold run time: 291379 ms
Total hot run time: 189817 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ce0eb2a3b60eff13756340f908383b026d88f45f, data reload: false

query1	0.04	0.03	0.05
query2	0.08	0.04	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.40	0.42	0.39
query6	1.15	0.66	0.66
query7	0.03	0.02	0.01
query8	0.03	0.04	0.03
query9	0.58	0.52	0.53
query10	0.58	0.58	0.56
query11	0.16	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.73	2.74	2.70
query15	0.92	0.84	0.86
query16	0.37	0.38	0.38
query17	1.04	1.02	1.03
query18	0.22	0.20	0.20
query19	1.95	1.78	2.00
query20	0.01	0.01	0.01
query21	15.37	0.89	0.55
query22	0.76	1.19	0.64
query23	14.97	1.38	0.60
query24	6.97	1.60	1.12
query25	0.47	0.13	0.24
query26	0.65	0.16	0.14
query27	0.05	0.06	0.05
query28	9.25	0.83	0.44
query29	12.54	3.97	3.28
query30	0.24	0.08	0.06
query31	2.83	0.59	0.37
query32	3.23	0.53	0.46
query33	2.99	3.08	3.02
query34	15.67	5.15	4.50
query35	4.53	4.48	4.56
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.05	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.57 s
Total hot run time: 30.76 s

@wyxxxcat wyxxxcat closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants