Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](docker) Starting thirdpaty script with only the reserve-ports parameter does not work #47578

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

zgxme
Copy link
Contributor

@zgxme zgxme commented Feb 7, 2025

What problem does this PR solve?

Related PR: #47262

Problem Summary:
Starting thirdpaty script with only the reserve-ports parameter does not work

./run-thirdparties-docker.sh --reserve-ports                                  

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zgxme
Copy link
Contributor Author

zgxme commented Feb 7, 2025

run buildall

@zgxme
Copy link
Contributor Author

zgxme commented Feb 7, 2025

run buildall

@zgxme zgxme requested a review from Thearas February 7, 2025 05:36
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by anyone and no changes requested.

@hello-stephen hello-stephen merged commit 7c70506 into apache:master Feb 7, 2025
28 of 32 checks passed
@zgxme zgxme deleted the docker-0207 branch February 7, 2025 07:42
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
…arameter does not work (#47578)

### What problem does this PR solve?

Related PR: #47262

Problem Summary:
Starting thirdpaty script with only the reserve-ports parameter does not
work
```bash
./run-thirdparties-docker.sh --reserve-ports                                  
```
zgxme added a commit to zgxme/doris that referenced this pull request Feb 7, 2025
…rve-ports parameter does not work (apache#47578)

Related PR: apache#47262

Problem Summary:
Starting thirdpaty script with only the reserve-ports parameter does not
work
```bash
./run-thirdparties-docker.sh --reserve-ports
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants