Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](compile) Initialize the KerberosTicketEntry struct variable in kerberos ticket. #47826

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

zhangm365
Copy link
Contributor

@zhangm365 zhangm365 commented Feb 12, 2025

What problem does this PR solve?

Related PR: #47299

Problem Summary:
fix the KerberosTicketEntry entry initialization to enable compile pass.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangm365 zhangm365 changed the title Fix the variable initialization in kerberos_ticket_mgr.cpp. Fix the variable initialization in kerberos ticket. Feb 17, 2025
@zhangm365 zhangm365 changed the title Fix the variable initialization in kerberos ticket. [Fix] Initialize the KerberosTicketEntry struct variable in kerberos ticket. Feb 17, 2025
@zhangm365
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 43.43% (11528/26545)
Line Coverage: 33.57% (97005/289006)
Region Coverage: 32.69% (49697/152027)
Branch Coverage: 28.44% (24994/87888)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60cdef88da46e52bb60c6e9e721487d0deb33954_60cdef88da46e52bb60c6e9e721487d0deb33954/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@morningman morningman self-assigned this Feb 19, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 31681 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

------ Round 1 ----------------------------------
q1	17581	5307	5078	5078
q2	2057	310	175	175
q3	10469	1366	740	740
q4	10246	1011	534	534
q5	7568	2500	2325	2325
q6	196	177	137	137
q7	909	762	622	622
q8	9326	1368	1177	1177
q9	4897	4588	4685	4588
q10	6832	2316	1890	1890
q11	478	284	256	256
q12	355	358	217	217
q13	17772	3670	3098	3098
q14	224	229	209	209
q15	502	465	446	446
q16	629	614	574	574
q17	576	862	350	350
q18	6934	6246	6294	6246
q19	1844	971	573	573
q20	316	334	190	190
q21	2775	2387	1956	1956
q22	379	333	300	300
Total cold run time: 102865 ms
Total hot run time: 31681 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5197	5127	5116	5116
q2	238	332	232	232
q3	2165	2679	2296	2296
q4	1421	1867	1345	1345
q5	4267	4171	4174	4171
q6	209	164	124	124
q7	1894	1860	1817	1817
q8	2667	2591	2587	2587
q9	7281	7038	7245	7038
q10	3060	3223	2822	2822
q11	582	512	500	500
q12	700	798	622	622
q13	3490	4118	3345	3345
q14	282	292	274	274
q15	516	480	456	456
q16	655	666	627	627
q17	1155	1572	1368	1368
q18	7625	7300	7389	7300
q19	830	824	980	824
q20	1957	2042	1856	1856
q21	5412	5054	4878	4878
q22	612	585	555	555
Total cold run time: 52215 ms
Total hot run time: 50153 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183966 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

query1	963	376	384	376
query2	6534	1848	1810	1810
query3	6797	220	215	215
query4	26631	23732	23553	23553
query5	4314	698	498	498
query6	301	196	209	196
query7	4599	506	298	298
query8	298	245	238	238
query9	8619	2546	2542	2542
query10	459	311	258	258
query11	15423	15118	14963	14963
query12	164	109	101	101
query13	1675	518	388	388
query14	8876	6391	6364	6364
query15	226	203	175	175
query16	7177	635	450	450
query17	1207	741	555	555
query18	1964	405	316	316
query19	233	195	164	164
query20	126	119	116	116
query21	213	123	103	103
query22	4294	4271	4257	4257
query23	33694	32914	32935	32914
query24	8115	2410	2409	2409
query25	559	443	388	388
query26	1223	270	155	155
query27	2615	479	348	348
query28	4240	2417	2392	2392
query29	756	556	444	444
query30	232	181	154	154
query31	908	845	794	794
query32	74	61	62	61
query33	588	385	301	301
query34	775	854	536	536
query35	798	817	741	741
query36	969	991	906	906
query37	120	92	74	74
query38	4185	4296	4235	4235
query39	1446	1392	1384	1384
query40	207	118	104	104
query41	55	50	49	49
query42	127	110	113	110
query43	490	490	481	481
query44	1303	806	796	796
query45	181	167	168	167
query46	883	1054	664	664
query47	1733	1768	1722	1722
query48	403	438	307	307
query49	773	508	431	431
query50	702	729	420	420
query51	4204	4197	4074	4074
query52	111	104	98	98
query53	231	252	187	187
query54	502	480	427	427
query55	88	89	85	85
query56	275	261	256	256
query57	1162	1161	1074	1074
query58	243	233	240	233
query59	2589	2706	2466	2466
query60	303	273	260	260
query61	121	145	118	118
query62	809	717	674	674
query63	243	195	200	195
query64	4324	1005	657	657
query65	3230	3164	3174	3164
query66	1130	402	303	303
query67	15940	15367	15270	15270
query68	7328	778	523	523
query69	489	303	263	263
query70	1192	1100	1102	1100
query71	412	286	276	276
query72	5711	3677	3534	3534
query73	758	745	364	364
query74	9122	9177	8733	8733
query75	3165	3153	2691	2691
query76	3147	1156	736	736
query77	487	437	286	286
query78	9896	10075	9266	9266
query79	2254	855	621	621
query80	593	516	435	435
query81	517	276	245	245
query82	431	124	99	99
query83	176	167	156	156
query84	243	96	75	75
query85	792	350	311	311
query86	381	309	304	304
query87	4600	4471	4599	4471
query88	4116	2231	2224	2224
query89	395	329	315	315
query90	1899	195	202	195
query91	137	145	113	113
query92	76	60	61	60
query93	1816	1036	595	595
query94	676	414	296	296
query95	359	275	258	258
query96	512	561	286	286
query97	2826	2788	2731	2731
query98	236	206	192	192
query99	1304	1458	1248	1248
Total cold run time: 270798 ms
Total hot run time: 183966 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.41	0.43	0.39
query6	1.16	0.67	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.59	0.52	0.55
query10	0.58	0.58	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.59
query14	2.73	2.74	2.70
query15	0.93	0.84	0.85
query16	0.37	0.40	0.38
query17	1.06	1.07	1.03
query18	0.22	0.20	0.20
query19	1.88	1.83	2.03
query20	0.01	0.02	0.01
query21	15.35	0.89	0.55
query22	0.76	1.29	0.80
query23	14.76	1.38	0.62
query24	10.70	1.37	0.41
query25	0.43	0.26	0.14
query26	0.87	0.18	0.15
query27	0.05	0.04	0.05
query28	6.48	0.77	0.43
query29	12.55	3.96	3.32
query30	0.25	0.09	0.06
query31	2.83	0.58	0.38
query32	3.22	0.54	0.46
query33	2.96	3.03	3.03
query34	15.88	5.19	4.55
query35	4.59	4.58	4.56
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.05	0.03
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.71 s
Total hot run time: 30.47 s

zhangm365 added a commit to zhangm365/doris that referenced this pull request Feb 19, 2025
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 43.83% (11635/26545)
Line Coverage: 33.75% (97543/289020)
Region Coverage: 32.84% (49925/152023)
Branch Coverage: 28.55% (25090/87882)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60cdef88da46e52bb60c6e9e721487d0deb33954_60cdef88da46e52bb60c6e9e721487d0deb33954/report/index.html

@morningman
Copy link
Contributor

run buildall

@zhangm365 zhangm365 changed the title [Fix] Initialize the KerberosTicketEntry struct variable in kerberos ticket. [Fix](KerberosTicketEntry) Initialize the KerberosTicketEntry struct variable in kerberos ticket. Feb 26, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 31760 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d4dbe6fcc64ac01904e7f9386740f41217e8b419, data reload: false

------ Round 1 ----------------------------------
q1	17602	5242	5095	5095
q2	2048	313	173	173
q3	10387	1330	714	714
q4	10216	1027	542	542
q5	7526	2336	2353	2336
q6	182	166	137	137
q7	896	756	590	590
q8	9294	1325	1075	1075
q9	5154	4687	4824	4687
q10	6845	2325	1886	1886
q11	482	275	257	257
q12	347	370	221	221
q13	17776	3774	3132	3132
q14	243	221	234	221
q15	537	473	471	471
q16	625	610	597	597
q17	557	883	332	332
q18	6854	6346	6269	6269
q19	1218	969	545	545
q20	319	328	196	196
q21	2881	2259	1978	1978
q22	364	337	306	306
Total cold run time: 102353 ms
Total hot run time: 31760 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5141	5126	5129	5126
q2	243	337	231	231
q3	2208	2704	2360	2360
q4	1470	1886	1387	1387
q5	4292	4151	4187	4151
q6	210	162	123	123
q7	1913	1832	1809	1809
q8	2637	2596	2622	2596
q9	7402	7279	7229	7229
q10	3068	3328	2883	2883
q11	581	522	480	480
q12	722	814	659	659
q13	3832	4208	3541	3541
q14	307	322	289	289
q15	495	463	480	463
q16	663	713	677	677
q17	1162	1655	1355	1355
q18	8052	7321	7396	7321
q19	768	785	874	785
q20	1966	2093	1878	1878
q21	5423	5045	4844	4844
q22	621	584	546	546
Total cold run time: 53176 ms
Total hot run time: 50733 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184342 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d4dbe6fcc64ac01904e7f9386740f41217e8b419, data reload: false

query1	1010	392	394	392
query2	6534	1865	1805	1805
query3	6792	222	221	221
query4	26072	23501	23278	23278
query5	4359	700	494	494
query6	304	192	176	176
query7	4609	502	291	291
query8	300	235	239	235
query9	8603	2582	2574	2574
query10	463	327	260	260
query11	15615	15048	14917	14917
query12	154	108	104	104
query13	1660	512	387	387
query14	9261	6042	6566	6042
query15	204	192	176	176
query16	7223	601	470	470
query17	1179	692	537	537
query18	1958	388	299	299
query19	183	178	145	145
query20	124	115	116	115
query21	213	122	103	103
query22	4251	4292	4656	4292
query23	34483	33632	33151	33151
query24	7801	2379	2395	2379
query25	564	467	425	425
query26	1234	264	153	153
query27	2606	453	318	318
query28	4416	2416	2376	2376
query29	728	539	420	420
query30	232	184	167	167
query31	953	849	789	789
query32	73	66	65	65
query33	572	347	287	287
query34	783	847	492	492
query35	787	815	727	727
query36	954	967	895	895
query37	119	101	77	77
query38	4157	4116	4243	4116
query39	1457	1406	1429	1406
query40	214	118	108	108
query41	59	59	55	55
query42	123	107	103	103
query43	493	510	467	467
query44	1302	790	791	790
query45	180	177	162	162
query46	864	1055	647	647
query47	1779	1814	1743	1743
query48	386	417	310	310
query49	784	537	437	437
query50	684	735	423	423
query51	4191	4152	4157	4152
query52	108	103	93	93
query53	225	256	188	188
query54	494	489	415	415
query55	84	86	81	81
query56	277	309	273	273
query57	1171	1178	1080	1080
query58	264	243	273	243
query59	2862	2692	2613	2613
query60	270	265	259	259
query61	122	117	120	117
query62	797	725	665	665
query63	235	180	191	180
query64	4286	982	731	731
query65	3264	3170	3216	3170
query66	1126	403	299	299
query67	15851	15519	15538	15519
query68	9309	888	504	504
query69	461	301	256	256
query70	1233	1129	1116	1116
query71	468	300	270	270
query72	5526	3509	3706	3509
query73	785	736	344	344
query74	8956	9246	8734	8734
query75	4181	3258	2752	2752
query76	3635	1180	757	757
query77	978	384	279	279
query78	10188	9989	9246	9246
query79	3139	830	590	590
query80	707	526	457	457
query81	524	286	239	239
query82	693	129	97	97
query83	210	178	166	166
query84	296	99	80	80
query85	802	356	302	302
query86	389	320	284	284
query87	4519	4492	4494	4492
query88	3574	2206	2183	2183
query89	409	320	293	293
query90	1919	203	198	198
query91	138	138	114	114
query92	75	59	57	57
query93	2072	1084	582	582
query94	688	409	313	313
query95	363	273	265	265
query96	496	558	271	271
query97	3334	3412	3259	3259
query98	222	208	196	196
query99	1420	1404	1258	1258
Total cold run time: 277194 ms
Total hot run time: 184342 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d4dbe6fcc64ac01904e7f9386740f41217e8b419, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.25	0.07	0.07
query4	1.60	0.11	0.11
query5	0.56	0.55	0.54
query6	1.20	0.70	0.72
query7	0.03	0.02	0.02
query8	0.05	0.03	0.04
query9	0.58	0.54	0.53
query10	0.57	0.58	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.70	2.80	2.72
query15	0.91	0.84	0.85
query16	0.39	0.37	0.38
query17	0.98	1.00	1.02
query18	0.22	0.20	0.19
query19	1.90	1.82	1.99
query20	0.01	0.01	0.01
query21	15.36	0.93	0.54
query22	0.79	1.26	0.61
query23	14.86	1.39	0.62
query24	6.94	1.95	1.00
query25	0.50	0.32	0.12
query26	0.57	0.15	0.14
query27	0.05	0.05	0.05
query28	9.82	0.88	0.44
query29	12.62	3.93	3.28
query30	0.26	0.09	0.06
query31	2.81	0.58	0.37
query32	3.22	0.55	0.47
query33	3.00	3.01	3.09
query34	15.82	5.18	4.53
query35	4.57	4.54	4.52
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.31 s
Total hot run time: 30.94 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.76% (11933/26658)
Line Coverage: 34.20% (99841/291948)
Region Coverage: 33.36% (51107/153195)
Branch Coverage: 28.91% (25664/88762)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d4dbe6fcc64ac01904e7f9386740f41217e8b419_d4dbe6fcc64ac01904e7f9386740f41217e8b419/report/index.html
Increment Report: http://coverage.selectdb-in.cc/coverage/d4dbe6fcc64ac01904e7f9386740f41217e8b419_d4dbe6fcc64ac01904e7f9386740f41217e8b419/increment_report/index.html

@morningman morningman merged commit 237c702 into apache:master Feb 26, 2025
23 of 26 checks passed
@morningman morningman changed the title [Fix](KerberosTicketEntry) Initialize the KerberosTicketEntry struct variable in kerberos ticket. [Fix](compile) Initialize the KerberosTicketEntry struct variable in kerberos ticket. Feb 26, 2025
zhiqiang-hhhh pushed a commit to zhiqiang-hhhh/doris that referenced this pull request Feb 27, 2025
…kerberos ticket. (apache#47826)

### What problem does this PR solve?

Related PR: apache#47299

Problem Summary:
fix the `KerberosTicketEntry entry` initialization to enable compile pass.
seawinde pushed a commit to seawinde/doris that referenced this pull request Feb 28, 2025
…kerberos ticket. (apache#47826)

### What problem does this PR solve?

Related PR: apache#47299

Problem Summary:
fix the `KerberosTicketEntry entry` initialization to enable compile pass.
mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Mar 4, 2025
…kerberos ticket. (apache#47826)

### What problem does this PR solve?

Related PR: apache#47299

Problem Summary:
fix the `KerberosTicketEntry entry` initialization to enable compile pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x-experimental dev/3.0.x-experimental reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants