-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](jvm) the jvm opt should only be set once #48335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
This was referenced Feb 25, 2025
Merged
TPC-H: Total hot run time: 31842 ms
|
TPC-DS: Total hot run time: 192905 ms
|
ClickBench: Total hot run time: 30.72 s
|
morningman
added a commit
that referenced
this pull request
Feb 26, 2025
CalvinKirs
approved these changes
Feb 26, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
suxiaogang223
approved these changes
Feb 26, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
### What problem does this PR solve? Introduced from #47299 the `SetEnvIfNecessary` may be called multiple times, and in #47299, we changed `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 0);` to `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 1);` so it will add `krb5 path` at the end of `LIBHDFS_OPTS` and set it every time, so `LIBHDFS_OPTS` becomes longer and longer. This PR fix this issue by calling `SetEnvIfNecessary` only once
dataroaring
pushed a commit
that referenced
this pull request
Feb 26, 2025
…8342) Cherry-picked from #48335 Co-authored-by: Mingyu Chen (Rayner) <[email protected]>
morningman
added a commit
that referenced
this pull request
Feb 26, 2025
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Feb 27, 2025
### What problem does this PR solve? Introduced from apache#47299 the `SetEnvIfNecessary` may be called multiple times, and in apache#47299, we changed `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 0);` to `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 1);` so it will add `krb5 path` at the end of `LIBHDFS_OPTS` and set it every time, so `LIBHDFS_OPTS` becomes longer and longer. This PR fix this issue by calling `SetEnvIfNecessary` only once
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Feb 28, 2025
### What problem does this PR solve? Introduced from apache#47299 the `SetEnvIfNecessary` may be called multiple times, and in apache#47299, we changed `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 0);` to `setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 1);` so it will add `krb5 path` at the end of `LIBHDFS_OPTS` and set it every time, so `LIBHDFS_OPTS` becomes longer and longer. This PR fix this issue by calling `SetEnvIfNecessary` only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.9-merged
dev/3.0.5-merged
p0_b
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Introduced from #47299
the
SetEnvIfNecessary
may be called multiple times, and in #47299,we changed
setenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 0);
tosetenv("LIBHDFS_OPTS", libhdfs_opts.c_str(), 1);
so it will add
krb5 path
at the end ofLIBHDFS_OPTS
and set it every time,so
LIBHDFS_OPTS
becomes longer and longer.This PR fix this issue by calling
SetEnvIfNecessary
only onceRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)