DRILL-4521: Map variance() and stddev() to var_samp() and stddev_samp() respectiv… #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class TestAggregationQueries extends PlanTestBase { | ||
|
|
||
| @Test // DRILL-4521 | ||
| public void testVariance() throws Exception { |
There was a problem hiding this comment.
Can you call these ensureVarianceIsAggregateReduced and ensureStddevIsAggregateReduced or something similar?
…ely, and allow for DrillReduceAggregateRule to apply to them test name change
minji-kim
changed the title
|
+1 |
vkorukanti
pushed a commit
to vkorukanti/drill
that referenced
this pull request
Apr 12, 2016
…() respectively, and allow for DrillReduceAggregateRule to apply to them test name change this closes apache#437
gparai
pushed a commit
to gparai/drill
that referenced
this pull request
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ely, and allow for DrillReduceAggregateRule to apply to them
Right now, variance() and stddev() is not mapped to var_samp() and stddev_samp() respectively, and they cannot be reduced to sums of squares (by DrillReduceAggregateRule). DrillReduceAggregateRule allows variance/stddev functions to be aggregated over 2-phase aggregation. Without this, stddev/variance is always done in a single phase aggregation. Added test cases to verify.