fix search query to check for the specific type of indexes it requires instead of using capabilities #17662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of using capabilities
maytasm
approved these changes
Jan 24, 2025
gianm
approved these changes
Jan 27, 2025
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jan 27, 2025
…s instead of using capabilities (apache#17662) * fix search query to check for the specific type of indexes it requires instead of using capabilities * cleanup * add comment
317brian
pushed a commit
to 317brian/druid
that referenced
this pull request
Jan 28, 2025
…s instead of using capabilities (apache#17662) * fix search query to check for the specific type of indexes it requires instead of using capabilities * cleanup * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue noticed in #16577 (comment).
The problem is that the search query was using
ColumnCapabilities.hasBitmapIndexes()to check if it could use the indexes strategy, which used to be ok when there were only indexes on string columns and so every column with that set would also have aDictionaryEncodedStringValueIndex, but is no longer the case.To fix, the search query now explicitly checks for columns having a
DictionaryEncodedStringValueIndexavailable since that is what the 'use indexes' strategy requires.The added test fails without the code changes in this PR.
This PR has: