fix missing required columns of CursorBuildSpec from RowFilterPolicy #17664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: * RowFilterPolicy.visit now uses new method FilteredCursorFactory.addFilter to re-use the CursorBuildSpec transform of FilteredCursorFactory of adding a filter and its required columns to a CursorBuildSpec * Added javadoc to CursorFactory, CursorHolder, and CursorBuildSpec to clarify usage
…urce-filter-policy-fix-spec-transform
gianm
reviewed
Jan 27, 2025
| * {@link Filter#getRequiredColumns()} which are not present in {@link #virtualColumns} will be added to the | ||
| * existing set of {@link #physicalColumns}. | ||
| */ | ||
| public CursorBuildSpecBuilder andFilter( |
There was a problem hiding this comment.
please include tests for this method specifically, exercising cases like:
filteris null,filterToAddis nonnullfilterToAddis null,filterToAddis null- both filters are nonnull
- the
filterToAddreferences a column that the previous build spec doesn't reference
…urce-filter-policy-fix-spec-transform
gianm
approved these changes
Jan 27, 2025
clintropolis
deleted the
restricted-datasource-filter-policy-fix-spec-transform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes:
RowFilterPolicy.visitandFilteredCursorFactory.makeCursorHoldernow use new methodCursorBuildSpecBuilder.andFilterto re-use theCursorBuildSpectransform ofFilteredCursorFactoryof adding a filter and its required columns to aCursorBuildSpecCursorFactory,CursorHolder, andCursorBuildSpecto clarify usageThis PR has: