Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window function tests to quidem #17687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weishiuntsai
Copy link
Contributor

@weishiuntsai weishiuntsai commented Jan 30, 2025

Description

This PR added 34 sets of QA window function tests to quidem. These tests cover window functions in a more comprehensive way. Each test has a mixture of positive tests and negative tests. There are a total of 23072 queries in these tests. They use the existing kttm dataset.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

This PR migrated 34 sets of QA window function tests to quidem. These tests cover window functions in a comprehensive way.  Each test has a mixture of positive tests and negative tests.  There are a total of 23072 queries in these tests.  They use the existing kttm dataset.
@weishiuntsai weishiuntsai changed the title Migrate window function tests to quidem Add window function tests to quidem Jan 31, 2025
@cryptoe
Copy link
Contributor

cryptoe commented Jan 31, 2025

@weishiuntsai Could you please tell us how much does the pipeline runtime increase after these test cases get added ?

@weishiuntsai
Copy link
Contributor Author

On my MacBook, this particular set of tests ran for about 3 minutes. The total run time of druid-quidem-ut in the pipeline from this particular PR run was about 13 minutes.
[INFO] druid-quidem-ut .................................... SUCCESS [13:26 min]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants