Skip to content

Commit

Permalink
fix TS5042 on github action build
Browse files Browse the repository at this point in the history
  • Loading branch information
openlg committed May 16, 2024
1 parent 910e681 commit bc339e5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ jobs:
run: npm install -g [email protected] && pnpm i

- name: Build Packages
run:
run: |
npm run build --workspace=./packages/dubbo-observable
npm run build --workspace=./packages/dubbo
npm run build --workspace=./packages/dubbo-node
- name: Continuous Integration
run:
run: |
npm run jasmine --workspace=./packages/dubbo
npm run jasmine --workspace=./packages/dubbo-node
Expand Down
8 changes: 4 additions & 4 deletions packages/dubbo-observable/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
// limitations under the License.


export type { ObservableOptions, Observable } from "./observable";
export { createObservable } from "./observable";
export type { ObservableOptions, Observable } from "./observable.js";
export { createObservable } from "./observable.js";

export type { MeterCollectorOptions, MetricOptions } from "./meter-collector";
export { MeterCollector, ProviderMeterCollector, ConsumerMeterCollector, ValueType } from "./meter-collector";
export type { MeterCollectorOptions, MetricOptions } from "./meter-collector.js";
export { MeterCollector, ProviderMeterCollector, ConsumerMeterCollector, ValueType } from "./meter-collector.js";
2 changes: 1 addition & 1 deletion packages/dubbo-observable/src/meter-collector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type {
UpDownCounter,
} from '@opentelemetry/api'
import { metrics, ValueType } from '@opentelemetry/api';
import { QpsCounter } from './qps-counter';
import { QpsCounter } from './qps-counter.js';

export { ValueType } from "@opentelemetry/api";
export type { MetricOptions } from "@opentelemetry/api";
Expand Down
5 changes: 1 addition & 4 deletions packages/dubbo-observable/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"files": ["src/index.ts"],
"include": ["src/**/*.spec.ts"],
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"resolveJsonModule": true
}
"extends": "../../tsconfig.base.json"
}

0 comments on commit bc339e5

Please sign in to comment.