Skip to content
23 changes: 21 additions & 2 deletions src/dubbo/classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import abc
import threading
from typing import Any, Callable, Optional, Union

from typing import Any, Callable, Optional, Union,Type
from abc import ABC, abstractmethod
from dubbo.types import DeserializingFunction, RpcType, RpcTypes, SerializingFunction

__all__ = [
Expand Down Expand Up @@ -244,3 +245,21 @@ class ReadWriteStream(ReadStream, WriteStream, abc.ABC):
"""

pass


class Codec(ABC):
def __init__(self, model_type: Optional[Type[Any]] = None, **kwargs):
self.model_type = model_type

@abstractmethod
def encode(self, data: Any) -> bytes:
pass

@abstractmethod
def decode(self, data: bytes) -> Any:
pass

class CodecHelper:
@staticmethod
def get_class():
return Codec
175 changes: 109 additions & 66 deletions src/dubbo/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import threading
from typing import Optional
import inspect
from typing import Optional, Callable, List, Type, Any, get_type_hints

from dubbo.bootstrap import Dubbo
from dubbo.classes import MethodDescriptor
Expand All @@ -31,6 +33,7 @@
SerializingFunction,
)
from dubbo.url import URL
from dubbo.codec import DubboTransportService

__all__ = ["Client"]

Expand Down Expand Up @@ -61,11 +64,17 @@ def _initialize(self):
return

# get the protocol
protocol = extensionLoader.get_extension(Protocol, self._reference.protocol)()
protocol = extensionLoader.get_extension(
Protocol, self._reference.protocol
)()

registry_config = self._dubbo.registry_config

self._protocol = RegistryProtocol(registry_config, protocol) if self._dubbo.registry_config else protocol
self._protocol = (
RegistryProtocol(registry_config, protocol)
if registry_config
else protocol
)

# build url
reference_url = self._reference.to_url()
Expand All @@ -82,82 +91,116 @@ def _initialize(self):

self._initialized = True

def unary(
@classmethod
def _infer_types_from_interface(cls, interface: Callable) -> tuple:
"""
Infer method name, parameter types, and return type from a callable.
"""
try:
type_hints = get_type_hints(interface)
sig = inspect.signature(interface)
method_name = interface.__name__
params = list(sig.parameters.values())

# skip 'self' for bound methods
if params and params[0].name == "self":
params = params[1:]

param_types = [type_hints.get(p.name, Any) for p in params]
return_type = type_hints.get("return", Any)

return method_name, param_types, return_type
except Exception:
return interface.__name__, [Any], Any

def _create_rpc_callable(
self,
method_name: str,
rpc_type: str,
interface: Optional[Callable] = None,
method_name: Optional[str] = None,
params_types: Optional[List[Type]] = None,
return_type: Optional[Type] = None,
codec: Optional[str] = None,
request_serializer: Optional[SerializingFunction] = None,
response_deserializer: Optional[DeserializingFunction] = None,
default_method_name: str = "rpc_call",
) -> RpcCallable:
return self._callable(
MethodDescriptor(
method_name=method_name,
arg_serialization=(request_serializer, None),
return_serialization=(None, response_deserializer),
rpc_type=RpcTypes.UNARY.value,
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also hope to see the implementation on the server side

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnzakii
If you don't mind can you explain me about this

like most of the work of server can be handle by the rpc handler

or
Am i missing something ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can review the proposal I sent in Slack, which also contains the corresponding Server interface design. You should also implement the construction method descriptors on the Server side, select the serialization method, and so on.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok
Now i understand
Thx for clarification

Create RPC callable with the specified type.
"""
if interface is None and method_name is None:
raise ValueError("Either 'interface' or 'method_name' must be provided")

# Start with explicit values
m_name = method_name
p_types = params_types
r_type = return_type

# Infer from interface if needed
if interface:
if p_types is None or r_type is None or m_name is None:
inf_name, inf_params, inf_return = self._infer_types_from_interface(
interface
)
m_name = m_name or inf_name
p_types = p_types or inf_params
r_type = r_type or inf_return

# Fallback to default
m_name = m_name or default_method_name

# Determine serializers
if request_serializer and response_deserializer:
req_ser = request_serializer
res_deser = response_deserializer
else:
req_ser, res_deser = DubboTransportService.create_serialization_functions(
codec or "json", # fallback to json
parameter_types=p_types,
return_type=r_type,
)

# Create MethodDescriptor
descriptor = MethodDescriptor(
method_name=m_name,
arg_serialization=(req_ser, None),
return_serialization=(None, res_deser),
rpc_type=rpc_type,
)

def client_stream(
self,
method_name: str,
request_serializer: Optional[SerializingFunction] = None,
response_deserializer: Optional[DeserializingFunction] = None,
) -> RpcCallable:
return self._callable(
MethodDescriptor(
method_name=method_name,
arg_serialization=(request_serializer, None),
return_serialization=(None, response_deserializer),
rpc_type=RpcTypes.CLIENT_STREAM.value,
)
return self._callable(descriptor)

def unary(self, **kwargs) -> RpcCallable:
return self._create_rpc_callable(
rpc_type=RpcTypes.UNARY.value, default_method_name="unary", **kwargs
)

def server_stream(
self,
method_name: str,
request_serializer: Optional[SerializingFunction] = None,
response_deserializer: Optional[DeserializingFunction] = None,
) -> RpcCallable:
return self._callable(
MethodDescriptor(
method_name=method_name,
arg_serialization=(request_serializer, None),
return_serialization=(None, response_deserializer),
rpc_type=RpcTypes.SERVER_STREAM.value,
)
def client_stream(self, **kwargs) -> RpcCallable:
return self._create_rpc_callable(
rpc_type=RpcTypes.CLIENT_STREAM.value,
default_method_name="client_stream",
**kwargs,
)

def bi_stream(
self,
method_name: str,
request_serializer: Optional[SerializingFunction] = None,
response_deserializer: Optional[DeserializingFunction] = None,
) -> RpcCallable:
# create method descriptor
return self._callable(
MethodDescriptor(
method_name=method_name,
arg_serialization=(request_serializer, None),
return_serialization=(None, response_deserializer),
rpc_type=RpcTypes.BI_STREAM.value,
)
def server_stream(self, **kwargs) -> RpcCallable:
return self._create_rpc_callable(
rpc_type=RpcTypes.SERVER_STREAM.value,
default_method_name="server_stream",
**kwargs,
)

def bi_stream(self, **kwargs) -> RpcCallable:
return self._create_rpc_callable(
rpc_type=RpcTypes.BI_STREAM.value, default_method_name="bi_stream", **kwargs
)

def _callable(self, method_descriptor: MethodDescriptor) -> RpcCallable:
"""
Generate a proxy for the given method
:param method_descriptor: The method descriptor.
:return: The proxy.
:rtype: RpcCallable
Generate a proxy for the given method.
"""
# get invoker
url = self._invoker.get_url()

# clone url
url = url.copy()
url.parameters[common_constants.METHOD_KEY] = method_descriptor.get_method_name()
# set method descriptor
url = self._invoker.get_url().copy()
url.parameters[common_constants.METHOD_KEY] = (
method_descriptor.get_method_name()
)
url.attributes[common_constants.METHOD_DESCRIPTOR_KEY] = method_descriptor

# create proxy
return self._callable_factory.get_callable(self._invoker, url)
19 changes: 19 additions & 0 deletions src/dubbo/codec/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from .dubbo_codec import DubboTransportService

__all__ = ['DubboTransportService']
Loading