Conversation
…ause they affect auto-color-determination in zrender Text (e.g., Element.getOutsideStroke), and consequently affect the bounding rect if stroke is added.
…t and root non-group-el bounding rect.
…ta structure. Fix that some label props were not updated during layout in certain places.
…the inconsistent behavior in pie label layout - (2.1) Previously calling `getBoundingRect` before textConfig applied (causing the result diff). (2.2) Previously adding extra margin for "auto text stroke" even if no auto text stroke added. Currently use ecomfe/zrender#1134 to uniform the behavior.
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21103@8dbf829 |
Ovilia
previously approved these changes
Jul 18, 2025
Ovilia
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
Most of the changes are the renaming of TS type and methods.
Require zrender ecomfe/zrender#1134
What does this PR do?
minMarginandtextMarginprocess are uniformed, both in impl and doc.getBoundingRectbefore textConfig applied (causing the result diff).Visual Test
Visual Regression Test Report.html.zip
No unexpected diff