Skip to content

[ CI ] Optimized ci #21110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plainheart merged 9 commits into from
Jul 16, 2025
Merged

[ CI ] Optimized ci #21110

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4e2fe2
refactor(ci): simplify Node.js setup and caching in CI workflow
souhailaS Jul 16, 2025
bf2c9ff
workflow dispatch for testing wf
souhailaS Jul 16, 2025
49e21b9
added on push for testing
souhailaS Jul 16, 2025
15dd95a
removed the on push trigger that was added just for testing
souhailaS Jul 16, 2025
f3d3f28
removed the on push trigger that was added for testing
souhailaS Jul 16, 2025
fb954fc
brought back the matrix
souhailaS Jul 16, 2025
d18d39a
added triggers to test
souhailaS Jul 16, 2025
8df0c3a
trigger ci.yml
souhailaS Jul 16, 2025
6e8e514
removed the push trigger
souhailaS Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,9 @@ jobs:
- name: Cache node modules
id: cache-dep
uses: actions/cache@v4
env:
cache-name: cache-node-modules
with:
path: node_modules
key: ${{ runner.os }}-lint-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}

- name: Install dependencies
if: steps.cache-dep.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -77,11 +75,9 @@ jobs:
- name: Cache node modules
id: cache-dep
uses: actions/cache@v4
env:
cache-name: cache-node-modules
with:
path: node_modules
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}

- name: Install dependencies
if: steps.cache-dep.outputs.cache-hit != 'true'
Expand All @@ -102,7 +98,7 @@ jobs:
run: |
export PR_PREVIEW_DIR='echarts-pr-preview'
mkdir -p $PR_PREVIEW_DIR
npm pack -pack-destination $PR_PREVIEW_DIR
npm pack --pack-destination $PR_PREVIEW_DIR
echo "PR_PREVIEW_DIR=$PR_PREVIEW_DIR" >> $GITHUB_ENV
- name: Save PR metadata and dist files
Expand Down