Skip to content

Conversation

@100pah
Copy link
Member

@100pah 100pah commented Jul 31, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • Fix TS types:
    • Some TS types are missing or not match to the current implementation. Those TS types serve the users' TS checking when composing a echarts option.
  • test case:
    • Migrate test cases "pie on amap" and "pie on bmap" to separate files to avoid affecting other cases if the relied external links are unavailable or disabled.

@Ovilia
Copy link
Contributor

Ovilia commented Aug 6, 2025

Sorry. I add this PR in the above commit by mistake.

@Ovilia Ovilia reopened this Aug 6, 2025
Ovilia
Ovilia previously approved these changes Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21147@4015f23

@plainheart plainheart added this to the 6.0.1 milestone Aug 11, 2025
@plainheart plainheart changed the title Fix missing or missmatched TS export types fix(types): Fix missing or missmatched TS export types Aug 11, 2025
@echarts-bot
Copy link

echarts-bot bot commented Aug 11, 2025

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@plainheart plainheart changed the title fix(types): Fix missing or missmatched TS export types fix(type): Fix missing or missmatched TS export types Aug 11, 2025
@100pah 100pah merged commit ae81f7a into master Aug 22, 2025
2 checks passed
@100pah 100pah deleted the fix/ts-export-type branch August 22, 2025 11:10
@echarts-bot
Copy link

echarts-bot bot commented Aug 22, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart changed the title fix(type): Fix missing or missmatched TS export types fix(type): fix missing or missmatched TS export types Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants