fix(line): fix areaStyle render error when dimension name is empty string#21219
Merged
Ovilia merged 1 commit intoapache:masterfrom Sep 2, 2025
Merged
fix(line): fix areaStyle render error when dimension name is empty string#21219Ovilia merged 1 commit intoapache:masterfrom
Ovilia merged 1 commit intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
Contributor
Author
|
@Ovilia Could you help to review the PR? Thanks! |
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21219@2e42179 |
Ovilia
approved these changes
Sep 2, 2025
Contributor
Ovilia
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix line area rendering issue when dataset dimension name is empty string.

Fixed issues
Details
Before: What was the problem?
When
dataset.dimensions[].nameis set to an empty string"", the line chart withareaStylerenders incorrectly.Root cause: In
getStackedOnPointsfunction, empty string dimension name fails truthiness check:This causes the function to return empty
stackedOnPointsarray, breaking area rendering.After: How does it behave after the fixing?
Changed the check to only reject
null/undefinedvalues:Empty string dimension names are now treated as valid dimension names for area rendering.
Document Info
Misc
ZRender Changes
Others
Merging options