Skip to content

feat(gauge): progress.color supports 'auto' #21224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 2 commits into from
Sep 8, 2025
Merged

feat(gauge): progress.color supports 'auto' #21224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d69383c
fix(gauge): apply correct color to progress when set to 'auto'
Aug 25, 2025
0b06d7f
feat(gauge): extract duplication to variable
Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/chart/gauge/GaugeView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ class GaugeView extends ChartView {
const focus = emphasisModel.get('focus');
const blurScope = emphasisModel.get('blurScope');
const emphasisDisabled = emphasisModel.get('disabled');
const autoColor = getColor(linearMap(data.get(valueDim, idx) as number, valueExtent, [0, 1], true));
if (showPointer) {
const pointer = data.getItemGraphicEl(idx) as ECSymbol;
const symbolStyle = data.getItemVisual(idx, 'style');
Expand All @@ -550,9 +551,7 @@ class GaugeView extends ChartView {


if (pointer.style.fill === 'auto') {
pointer.setStyle('fill', getColor(
linearMap(data.get(valueDim, idx) as number, valueExtent, [0, 1], true)
));
pointer.setStyle('fill', autoColor);
}

(pointer as ECElement).z2EmphasisLift = 0;
Expand All @@ -564,6 +563,9 @@ class GaugeView extends ChartView {
const progress = progressList[idx];
progress.useStyle(data.getItemVisual(idx, 'style'));
progress.setStyle(itemModel.getModel(['progress', 'itemStyle']).getItemStyle());
if (progress.style.fill === 'auto') {
progress.setStyle('fill', autoColor);
}
(progress as ECElement).z2EmphasisLift = 0;
setStatesStylesFromModel(progress, itemModel);
toggleHoverEmphasis(progress, focus, blurScope, emphasisDisabled);
Expand Down
52 changes: 52 additions & 0 deletions test/gauge-progress.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading