fix(candlestick): fix candlestick render error with series.encode
#21325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
plainheart
requested changes
Oct 23, 2025
Member
plainheart
left a comment
plainheart
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I left a few comments.
plainheart
reviewed
Oct 23, 2025
plainheart
requested changes
Oct 23, 2025
plainheart
changed the title
series.encode
plainheart
changed the title
series.encodeseries.encode
plainheart
changed the title
series.encodeseries.encode
plainheart
previously approved these changes
Oct 24, 2025
100pah
approved these changes
Oct 30, 2025
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21325@f94f221 |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes TypeError: Cannot read properties of undefined (reading 'sign') and displays horizontal candlesticks properly
Fixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information