Implement 101.8.4 Log Events #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilx
force-pushed
the
log-entries-to-events
branch
2 times, most recently
from
3b1f2ea to
01f8f35
Compare
wilx
force-pushed
the
log-entries-to-events
branch
2 times, most recently
from
e08eb73 to
689f09b
Compare
Log entries must be mapped into events by the Log Service implementation and delivered asynchronously to the Event Admin service (if present).
Having felix.eventadmin and felix.log both in runtime causes logged events to be doubled.
wilx
force-pushed
the
log-entries-to-events
branch
from
689f09b to
486c539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking around the felix.log I noticed that the spec section "101.8.4 Log Events" is not implemented in felix.log. So implemented it. Then when I wrote the test, I found out it was actually implemented in felix.eventadmin instead as per OSGi R4. It appears the Log events spec has moved into its own chapter in later releases of the spec and all responsibility for the implementation should be in the felix.log component. Removing the adapters is necessary, otherwise in environment with both felix.log and felix.eventadmin the log events are duplicated.
These changes are on top of the tiny-fixes2 branch (#359).